[U-Boot] git send-email and patch headers/subject line

[U-Boot] git send-email and patch headers/subject line

[Stephen Arnold]

Howdy:

I could swear this worked the last time I sent patches to the OE list
(at least it didn't need the gmail insecure app workaround so I guess
it was a while ago).

Anyway, the real commit msg starts with ARM, I git format-patch and
this time didn't touch the patches, then:

git send-email --to=test at lists.denx.de --confirm=always -M -1
--subject-prefix="U-Boot][PATCH v3"  outgoing/*

with two patches.  In my gmail I see the first patch email still gets
threaded with the original email (with only one patch) and gets the
U-Boot][PATCH v3 but not a 1/2.

The second one gets PATCH 2/2 but not the U-Boot or v3.  Is there a
trick to this I'm missing, or does it only work correctly without the
format-patch step?  Sorry, but git send-email has never been part of
the Gentoo process so I kinda rely on the wiki pages for "how to
submit patches" for things like this.  And this page:

http://www.denx.de/wiki/U-Boot/Patches

doesn't mention using the  U-Boot][PATCH  string in subject arg.  And
I think I just answered one of my questions; is "git format-patch -n
--cover-letter" required to get more than one patch to thread
correctly?

Thanks in advance for any help clearing this up.

Steve

[U-Boot] git send-email and patch headers/subject line

[Brüns, Stefan]

On Montag, 3. Oktober 2016 17:02:37 CEST Stephen Arnold wrote:
> Howdy:
> 
> I could swear this worked the last time I sent patches to the OE list
> (at least it didn't need the gmail insecure app workaround so I guess
> it was a while ago).
> 
> Anyway, the real commit msg starts with ARM, I git format-patch and
> this time didn't touch the patches, then:
> 
> git send-email --to=test at lists.denx.de --confirm=always -M -1
> --subject-prefix="U-Boot][PATCH v3"  outgoing/*

You should *not* add the [U-Boot] tag to the message, this is done by the 
mailinglist software.

The wiki states to use:
$> git format-patch --subject-prefix="PATCH v2"

Current git allows a simpler variant, "--reroll-count", or short "-v":
$> git format-patch -v 2


"git send-email" has no "--subject-prefix" nor "-M" nor "-<n>" option. Just 
use
$> git send-email --to=<xxx> --cc <yyy> outgoing/*

Formatting and sending patches are two independent steps. You can't apply/copy 
options from one command to the other.

Prior to sending the patch, you *should* edit the 0000-cover-letter.patch.

Kind regards,

Stefan

[U-Boot] git send-email and patch headers/subject line

[Stephen Arnold]

Thanks for the extra tidbits; I just updated my notes:

OE and U-Boot mailing list patch guidelines

<openembedded-core@lists.openembedded.org>
<u-boot@lists.denx.de>

Following git send-email man page setup, note that app passwords are
now required.
Replace <N> with number of commits; if N=1, can leave off cover
letter. Add vN for
patch revisions or use new variant.

git format-patch --cover-letter  --subject-prefix="PATCH v2" -o outgoing/
or
git format-patch -v 2

edit outgoing/0000-* (add Cc:. etc)

git send-email --to=u-boot at lists.denx.de --cc <foo@bar>  outgoing/*
or
git send-email --to=openembedded-core at lists.openembedded.org
--subject="meta-oe][PATCH" outgoing/*

As far as threading/reply-to settings, my .gitconfig has "chainreplyto
= false" in the sendemail section; do I need to set thread or add
--in-reply-to to make that work?  The man page doesn't seem too clear
on what the defaults should be or when to override.

Thanks again for the tips!

Steve

On Tue, Oct 4, 2016 at 8:10 AM, Br?ns, Stefan
<Stefan.Bruens@rwth-aachen.de> wrote:
> On Montag, 3. Oktober 2016 17:02:37 CEST Stephen Arnold wrote:
>> Howdy:
>>
>> I could swear this worked the last time I sent patches to the OE list
>> (at least it didn't need the gmail insecure app workaround so I guess
>> it was a while ago).
>>
>> Anyway, the real commit msg starts with ARM, I git format-patch and
>> this time didn't touch the patches, then:
>>
>> git send-email --to=test at lists.denx.de --confirm=always -M -1
>> --subject-prefix="U-Boot][PATCH v3"  outgoing/*
>
> You should *not* add the [U-Boot] tag to the message, this is done by the
> mailinglist software.
>
> The wiki states to use:
> $> git format-patch --subject-prefix="PATCH v2"
>
> Current git allows a simpler variant, "--reroll-count", or short "-v":
> $> git format-patch -v 2
>
>
> "git send-email" has no "--subject-prefix" nor "-M" nor "-<n>" option. Just
> use
> $> git send-email --to=<xxx> --cc <yyy> outgoing/*
>
> Formatting and sending patches are two independent steps. You can't apply/copy
> options from one command to the other.
>
> Prior to sending the patch, you *should* edit the 0000-cover-letter.patch.
>
> Kind regards,
>
> Stefan
>