From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pantelis Antoniou Date: Fri, 16 Apr 2004 10:24:56 +0300 Subject: [U-Boot-Users] Re: [patch #10/11] HUSH parser fixes. In-Reply-To: <20040415215453.821A1C109F@atlas.denx.de> References: <20040415215453.821A1C109F@atlas.denx.de> Message-ID: <407F8A48.7010100@intracom.gr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: >In message <406988DC.7040408@intracom.gr> you wrote: > >>The following patch fixes various shortcomings in the >>hush parser. >> >>1. A new test command was added. This is a simplified >> version of the one in the sh shell. >> >>2. A new exit command was added which terminates the >> current executing script. >> >>3. Handing of $? (exit code of last executed command), was >> wrong. Instead of being evaluated in the proper place >> it was evaluated once at the start of the evaluation. >> >> For example the following script worked like this. >> >> test 1 -eq 2 # set $? to 1 >> echo $? # outputs 1 >> test 1 -eq 1 # set $? to 0 >> echo $? # still outputs 1 >> >> Now it is fixed. >> > >Can you please re-submit a patch whioch included these 3 items only? > > Sure, coming right up. >>4. The simplified parser uses '(' and ')' for enclosing variables. >> This caused problems when migrating to hush because hash uses >> '{' and '}'. Modified to accept parentheses too. >> > >Sorry, but I reject this patch. I want hush to stay as bourne shell >compatible as possible. I'd much rather fix the simple command line >parser to use ``${...}'' instead. > > Could I at least make it a compile option? We have a number of boards in the field that would like to upgrade to hush without changing the configuration. >Best regards, > >Wolfgang Denk > > Regards Pantelis