[U-Boot-Users] [patch #4/6] Hush parser update.

[U-Boot-Users] [patch #4/6] Hush parser update.

[Pantelis Antoniou]

Wolfgang hi.

This is a resend of my previous patch with the parantheses conditionalized
on CONFIG_HUSH_OLD_PARSER_COMPATIBLE.

Regards

Pantelis

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: hush.diff
Url: http://lists.denx.de/pipermail/u-boot/attachments/20040416/c283cf06/attachment.txt 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: hush.diffstat
Url: http://lists.denx.de/pipermail/u-boot/attachments/20040416/c283cf06/attachment-0001.txt 

[U-Boot-Users] [patch #4/6] Hush parser update.

[Wolfgang Denk]

In message <4080101B.4040202@intracom.gr> you wrote:
> 
> This is a resend of my previous patch with the parantheses conditionalized
> on CONFIG_HUSH_OLD_PARSER_COMPATIBLE.

Thanks, added  -  except  for  the  CONFIG_HUSH_OLD_PARSER_COMPATIBLE
stuff.

I'm sorry, I understand exactly what you are trying to acchieve,  but
I  think  this is the wrong way of doing it. The main problem is that
the simple command parser was implemented wrong. I really repent that
I didn't fix this right from the beginning.

I cannot allow that this gets added to the hush shell, because  oncve
added we would never get rid of it again.


If you are interested in a compatible handling of the environment,  I
think  we should fix the simple parser to accept the ${var} notation,
too. For some transitional period we  could  allow  both  $(var)  and
${var}, before finally switching the simple parser to ${var} only.

If you are more concerned about updates of existing  devices  to  new
versions  of U-Boot, I think we should solve the problem differently,
for example by implementing a standalone application that can convert
the environment from the old format to the new one.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
Four thousand throats may be cut in one night by a running man.
	-- Klingon Soldier, "Day of the Dove", stardate unknown

[U-Boot-Users] [patch #4/6] Hush parser update.

[Pantelis Antoniou]

Wolfgang Denk wrote:

>In message <4080101B.4040202@intracom.gr> you wrote:
>
>>This is a resend of my previous patch with the parantheses conditionalized
>>on CONFIG_HUSH_OLD_PARSER_COMPATIBLE.
>>
>
>Thanks, added  -  except  for  the  CONFIG_HUSH_OLD_PARSER_COMPATIBLE
>stuff.
>
>I'm sorry, I understand exactly what you are trying to acchieve,  but
>I  think  this is the wrong way of doing it. The main problem is that
>the simple command parser was implemented wrong. I really repent that
>I didn't fix this right from the beginning.
>
>I cannot allow that this gets added to the hush shell, because  oncve
>added we would never get rid of it again.
>
>
>If you are interested in a compatible handling of the environment,  I
>think  we should fix the simple parser to accept the ${var} notation,
>too. For some transitional period we  could  allow  both  $(var)  and
>${var}, before finally switching the simple parser to ${var} only.
>
>If you are more concerned about updates of existing  devices  to  new
>versions  of U-Boot, I think we should solve the problem differently,
>for example by implementing a standalone application that can convert
>the environment from the old format to the new one.
>
>
Yeah I understand where you're coming from.

Anyway here is a patch that fixes the simple parser to also accept the
${var} notation.
Also attach is a patch for our boards that takes it into account, plus
a few other minor fixes.

We probably gonna keep internally the CONFIG_HUSH_OLD_PARSER_COMPATIBLE
for a few months until we update (manually) all the boards.

>Best regards,
>
>Wolfgang Denk
>
>
Regards

Pantelis

-------------- next part --------------
A non-text attachment was scrubbed...
Name: simple-parser.diff
Type: text/x-patch
Size: 956 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20040419/8a2f13e6/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: intracom.diff
Type: text/x-patch
Size: 4947 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20040419/8a2f13e6/attachment-0001.bin 

[U-Boot-Users] [patch #4/6] Hush parser update.

[Wolfgang Denk]

In message <40839F44.70802@intracom.gr> you wrote:
>
> Anyway here is a patch that fixes the simple parser to also accept the
> ${var} notation.
> Also attach is a patch for our boards that takes it into account, plus
> a few other minor fixes.

Added, thanks. But please  prepare  pre-formatted  CHANGELOG  entries
next time!

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
The human race is a race of cowards; and I am not  only  marching  in
that procession but carrying a banner.                   - Mark Twain