From: Pantelis Antoniou <panto@intracom.gr>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [patch #4/6] Hush parser update.
Date: Mon, 19 Apr 2004 12:43:32 +0300 [thread overview]
Message-ID: <40839F44.70802@intracom.gr> (raw)
In-Reply-To: <20040418095709.D1327C109F@atlas.denx.de>
Wolfgang Denk wrote:
>In message <4080101B.4040202@intracom.gr> you wrote:
>
>>This is a resend of my previous patch with the parantheses conditionalized
>>on CONFIG_HUSH_OLD_PARSER_COMPATIBLE.
>>
>
>Thanks, added - except for the CONFIG_HUSH_OLD_PARSER_COMPATIBLE
>stuff.
>
>I'm sorry, I understand exactly what you are trying to acchieve, but
>I think this is the wrong way of doing it. The main problem is that
>the simple command parser was implemented wrong. I really repent that
>I didn't fix this right from the beginning.
>
>I cannot allow that this gets added to the hush shell, because oncve
>added we would never get rid of it again.
>
>
>If you are interested in a compatible handling of the environment, I
>think we should fix the simple parser to accept the ${var} notation,
>too. For some transitional period we could allow both $(var) and
>${var}, before finally switching the simple parser to ${var} only.
>
>If you are more concerned about updates of existing devices to new
>versions of U-Boot, I think we should solve the problem differently,
>for example by implementing a standalone application that can convert
>the environment from the old format to the new one.
>
>
Yeah I understand where you're coming from.
Anyway here is a patch that fixes the simple parser to also accept the
${var} notation.
Also attach is a patch for our boards that takes it into account, plus
a few other minor fixes.
We probably gonna keep internally the CONFIG_HUSH_OLD_PARSER_COMPATIBLE
for a few months until we update (manually) all the boards.
>Best regards,
>
>Wolfgang Denk
>
>
Regards
Pantelis
-------------- next part --------------
A non-text attachment was scrubbed...
Name: simple-parser.diff
Type: text/x-patch
Size: 956 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20040419/8a2f13e6/attachment.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: intracom.diff
Type: text/x-patch
Size: 4947 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20040419/8a2f13e6/attachment-0001.bin
next prev parent reply other threads:[~2004-04-19 9:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-16 16:55 [U-Boot-Users] [patch #4/6] Hush parser update Pantelis Antoniou
2004-04-18 9:57 ` Wolfgang Denk
2004-04-19 9:43 ` Pantelis Antoniou [this message]
2004-04-22 14:54 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40839F44.70802@intracom.gr \
--to=panto@intracom.gr \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox