From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pantelis Antoniou Date: Mon, 19 Apr 2004 12:43:32 +0300 Subject: [U-Boot-Users] [patch #4/6] Hush parser update. In-Reply-To: <20040418095709.D1327C109F@atlas.denx.de> References: <20040418095709.D1327C109F@atlas.denx.de> Message-ID: <40839F44.70802@intracom.gr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: >In message <4080101B.4040202@intracom.gr> you wrote: > >>This is a resend of my previous patch with the parantheses conditionalized >>on CONFIG_HUSH_OLD_PARSER_COMPATIBLE. >> > >Thanks, added - except for the CONFIG_HUSH_OLD_PARSER_COMPATIBLE >stuff. > >I'm sorry, I understand exactly what you are trying to acchieve, but >I think this is the wrong way of doing it. The main problem is that >the simple command parser was implemented wrong. I really repent that >I didn't fix this right from the beginning. > >I cannot allow that this gets added to the hush shell, because oncve >added we would never get rid of it again. > > >If you are interested in a compatible handling of the environment, I >think we should fix the simple parser to accept the ${var} notation, >too. For some transitional period we could allow both $(var) and >${var}, before finally switching the simple parser to ${var} only. > >If you are more concerned about updates of existing devices to new >versions of U-Boot, I think we should solve the problem differently, >for example by implementing a standalone application that can convert >the environment from the old format to the new one. > > Yeah I understand where you're coming from. Anyway here is a patch that fixes the simple parser to also accept the ${var} notation. Also attach is a patch for our boards that takes it into account, plus a few other minor fixes. We probably gonna keep internally the CONFIG_HUSH_OLD_PARSER_COMPATIBLE for a few months until we update (manually) all the boards. >Best regards, > >Wolfgang Denk > > Regards Pantelis -------------- next part -------------- A non-text attachment was scrubbed... Name: simple-parser.diff Type: text/x-patch Size: 956 bytes Desc: not available Url : http://lists.denx.de/pipermail/u-boot/attachments/20040419/8a2f13e6/attachment.bin -------------- next part -------------- A non-text attachment was scrubbed... Name: intracom.diff Type: text/x-patch Size: 4947 bytes Desc: not available Url : http://lists.denx.de/pipermail/u-boot/attachments/20040419/8a2f13e6/attachment-0001.bin