From mboxrd@z Thu Jan 1 00:00:00 1970 From: sean chang Date: Tue, 29 Jun 2004 17:41:35 -0700 Subject: [U-Boot-Users] [PATCH] for Xilinx's ml300 board References: <20040629183141.GA28357@acmay.homeip.net> Message-ID: <40E20C3F.5F40541E@xilinx.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, Sorry for the mess. Apparently I missed a step in cleaning up the spacing for my patch. Please ignore this patch and I'll submit another one soon. Andrew, your points are well taken. I was planning on doing this in different steps but it doesn't seem like a good idea after all. I'll separate out the non-standard environment functions from IIC support and re-submit the patch. Further comments/suggestions are welcomed. Thanks, Sean Andrew May wrote: > > On Tue, Jun 29, 2004 at 09:06:51AM -0700, Sean Chang wrote: > > Hi Wolfgang, > > > > This is the first time I am submitting a patch, so if there is any problem > > please let me know and I'll be more than happy to fix it. > > > > This patch is applied against the u-boot 1.1.1 release. Basically it adds > > support for the ml300 board to read out its environment information stored > > on the EEPROM. > > I would think the more important feature is that IIC support is added. > I also wouldn't skip the fact that the OS independent code has changes as > well. > There are also a lot of tab to spaces conversions, that hide the real > changes. > > It would be up to Wolfgang if he wants the stuff redone, but I would like > to see a more complete change log. like > > CHANGELOG: > Patch by Sean Chang, 28 Jun 2004: > Updates to Virtex-II Pro/ml300 board > OS independent code to Xilinx EDK 6.2 > Added IIC support (with non-standard environment functions) > Add support for ml300 board to read out its environment > information stored on the EEPROM. > Convert Xilinx style environment vars to U-boot style vars. > > The non-standard env stuff should really be moved to a separate file so > people can use just the IIC support without pulling that garbage in. > > The whole xparameters.h file is really annoying. It makes the IPIF code > impossible to use on more than one board type without a recompile. That > may be OK for U-boot but it is horrible in the Linux kernel. > > These things really need some ()'s. > +#define XIIC_CR_REG_OFFSET 0x00+XIIC_REG_OFFSET /* Control Register */ > > ------------------------------------------------------- > This SF.Net email sponsored by Black Hat Briefings & Training. > Attend Black Hat Briefings & Training, Las Vegas July 24-29 - > digital self defense, top technical experts, no vendor pitches, > unmatched networking opportunities. Visit www.blackhat.com > _______________________________________________ > U-Boot-Users mailing list > U-Boot-Users at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/u-boot-users