[U-Boot-Users] [PATCH] Total5100 and Total5200 platform support

Wolfgang Denk
2004-07-05T13:22:18Z

In message <40E95290.3040607@freescale.com> you wrote:
>
> the attached patch adds support for the Total5100's and Total5200's LCD
> screen. By default only the logo is displayed because the environment
> variable "console" is set to "serial". By clearing this variable stdout
> and stderr will be displayed on the LCD. The patch should be applied
> after the initial (20040701) and the second patch (20040702).

Can you please fix this patch to use the standard console device
mechanism of U-Boot? Instead of introducing a new "console" variable.
the standard mechanism of assigning to the stdin / stdout / stderr
streams should be used.

I just learned that there are already other bad examples using such a
"console" setting:

File: Board: Maintainer:
board/eltec/elppc/misc.c ELPPC Frank Gottschling
board/netphone/phone_console.c NETPHONE Pantelis Antoniou
drivers/cfb_console.c ? Frank Gottschling

Frank & Pantelis, can you please submit patches to clean this up,
too? Let's get rid of this "console" stuff before anybody else copies
it. [Sorry that this escaped me so far.]

Best regards,

Wolfgang Denk

--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de
"What people have been reduced to are mere 3-D representations of
their own data." - Arthur Miller