[U-Boot-Users] [PATCH] Total5100 and Total5200 platform support

Wolfgang Denk
2004-07-06T07:19:15Z

Dear Pantelis,

in message <40EA413B.1000407@intracom.gr> you wrote:
>
> >I just learned that there are already other bad examples using such a
> >"console" setting:
> >
> >File: Board: Maintainer:
> >board/eltec/elppc/misc.c ELPPC Frank Gottschling
> >board/netphone/phone_console.c NETPHONE Pantelis Antoniou
> >drivers/cfb_console.c ? Frank Gottschling
...
> Excuse me Wolfgang but what is the problem?

The problem is that the files listed above invented a new,
non-standard mechanism for something which is already available and
thus should be done in a different way.

> In my board I don't use an extra console variable. I
> just wait for a key sequence to enable the lcd console
> which does use the standard u-boot mechanism.
>
> Have I missed something here?

See "board/netphone/phone_console.c":

...
331 /*
332 * Force console i/o to serial ?
333 */
334 if ((penv = getenv("console")) != NULL && strcmp(penv, "serial") == 0)
335 return 0;
...

Here you _do_ use an extra console variable.

Please get rid of this. Please the standard stdin / stdout / stderr
(here probably stdout) settings for this.

Best regards,

Wolfgang Denk

--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de
"Marriage is like a cage; one sees the birds outside desperate to get
in, and those inside desperate to get out." - Montaigne