From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pantelis Antoniou Date: Tue, 06 Jul 2004 10:16:58 +0300 Subject: [U-Boot-Users] [PATCH] Total5100 and Total5200 platform support In-Reply-To: <20040706071921.1213CC109F@atlas.denx.de> References: <20040706071921.1213CC109F@atlas.denx.de> Message-ID: <40EA51EA.9070101@intracom.gr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: >Dear Pantelis, > >in message <40EA413B.1000407@intracom.gr> you wrote: > >>>I just learned that there are already other bad examples using such a >>>"console" setting: >>> >>>File: Board: Maintainer: >>>board/eltec/elppc/misc.c ELPPC Frank Gottschling >>>board/netphone/phone_console.c NETPHONE Pantelis Antoniou >>>drivers/cfb_console.c ? Frank Gottschling >>> >... > >>Excuse me Wolfgang but what is the problem? >> > >The problem is that the files listed above invented a new, >non-standard mechanism for something which is already available and >thus should be done in a different way. > > >>In my board I don't use an extra console variable. I >>just wait for a key sequence to enable the lcd console >>which does use the standard u-boot mechanism. >> >>Have I missed something here? >> > >See "board/netphone/phone_console.c": > > ... > 331 /* > 332 * Force console i/o to serial ? > 333 */ > 334 if ((penv = getenv("console")) != NULL && strcmp(penv, "serial") == 0) > 335 return 0; > ... > >Here you _do_ use an extra console variable. > Oops, you're correct. I have forgotten about this because I don't actually use it anywhere. Attached patch just kills this. > >Please get rid of this. Please the standard stdin / stdout / stderr >(here probably stdout) settings for this. > >Best regards, > >Wolfgang Denk > > Regards Pantelis -------------- next part -------------- A non-text attachment was scrubbed... Name: console-kill.patch Type: text/x-patch Size: 428 bytes Desc: not available Url : http://lists.denx.de/pipermail/u-boot/attachments/20040706/855a5baf/attachment.bin