u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Casey Connolly <casey.connolly@linaro.org>
To: Quentin Schulz <foss+uboot@0leil.net>, u-boot@lists.denx.de
Cc: Tom Rini <trini@konsulko.com>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Andrew Goodbody <andrew.goodbody@linaro.org>,
	Peter Robinson <pbrobinson@gmail.com>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Simon Glass <sjg@chromium.org>,
	Quentin Schulz <quentin.schulz@cherry.de>
Subject: Re: [PATCH v3 0/2] cmd: ufetch: print Net feature when NET_LWIP=y, prettyfy if NET=n
Date: Tue, 5 May 2026 15:47:30 +0200	[thread overview]
Message-ID: <40dde65f-9dc6-465f-a053-31a90d75fce1@linaro.org> (raw)
In-Reply-To: <20260505-ufetch-net-v3-0-eee5eb9ca5ce@cherry.de>



On 05/05/2026 11:14, Quentin Schulz wrote:
> Make sure the Net feature is printed when NET_LWIP is enabled, not only
> when NET_LEGACY is.
> 
> Only print comma and following whitespace as separator if there was a
> feature printed before feature to be printed.
> 
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>

Reviewed-by: Casey Connolly <casey.connolly@linaro.org>

> ---
> Changes in v3:
> - migrated from bool plus ternary operator for setting the separator per
>   printf to a const char* which contains the separator to print, as
>   suggested by Simon,
> - Link to v2: https://patch.msgid.link/20260504-ufetch-net-v2-0-01bec4ca7169@cherry.de
> 
> Changes in v2:
> - added R-b trailers,
> - fixed spurious colon character before separator in cat,
> - Link to v1: https://patch.msgid.link/20260428-ufetch-net-v1-0-5d58c7618239@cherry.de
> 
> ---
> Quentin Schulz (2):
>       cmd: ufetch: show net feature when NET_LWIP is selected
>       cmd: ufetch: only show comma separator if there was a previous feature
> 
>  cmd/ufetch.c | 29 ++++++++++++++++++++---------
>  1 file changed, 20 insertions(+), 9 deletions(-)
> ---
> base-commit: 57460fde4ba84d67de4066ee1141e89e8139ed23
> change-id: 20260428-ufetch-net-1ba7553a20c7
> 
> Best regards,
> --  
> Quentin Schulz <quentin.schulz@cherry.de>
> 

-- 
// Casey (she/her)


  parent reply	other threads:[~2026-05-05 13:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-05  9:14 [PATCH v3 0/2] cmd: ufetch: print Net feature when NET_LWIP=y, prettyfy if NET=n Quentin Schulz
2026-05-05  9:14 ` [PATCH v3 1/2] cmd: ufetch: show net feature when NET_LWIP is selected Quentin Schulz
2026-05-05  9:14 ` [PATCH v3 2/2] cmd: ufetch: only show comma separator if there was a previous feature Quentin Schulz
2026-05-05 13:58   ` Simon Glass
2026-05-05 13:47 ` Casey Connolly [this message]
2026-05-05 14:14 ` [PATCH v3 0/2] cmd: ufetch: print Net feature when NET_LWIP=y, prettyfy if NET=n Casey Connolly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40dde65f-9dc6-465f-a053-31a90d75fce1@linaro.org \
    --to=casey.connolly@linaro.org \
    --cc=andrew.goodbody@linaro.org \
    --cc=foss+uboot@0leil.net \
    --cc=ilias.apalodimas@linaro.org \
    --cc=pbrobinson@gmail.com \
    --cc=quentin.schulz@cherry.de \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).