From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Wed, 23 May 2018 13:29:46 +0300
Subject: [U-Boot] [PATCH v1] x86: acpi: Adopt new version of iASL
	compiler
In-Reply-To: <CAEUhbmWx5zY-Lww9kZmO_gPHm2SpzNm1mAnSXuGG10GqBu6qPw@mail.gmail.com>
References: <20180523093802.68487-1-andriy.shevchenko@linux.intel.com>
 <CAEUhbmWx5zY-Lww9kZmO_gPHm2SpzNm1mAnSXuGG10GqBu6qPw@mail.gmail.com>
Message-ID: <40e3877de353004da151e6443b559106e2725871.camel@linux.intel.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wed, 2018-05-23 at 18:22 +0800, Bin Meng wrote:
> Hi Andy,
> 
> On Wed, May 23, 2018 at 5:38 PM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > The commit
> > 
> >   f9a88a4c1cd0 ("iASL: Enhance the -tc option (create AML hex file
> > in C)")
> > 
> > in ACPICA project changed a template of the a of variable that is
> > used
> 
> a template of the a of variable? Cannot understand this.

"a template of the variable"

> 
> > in the generated C-file. Now, instead of hard coded "AmlCode" the
> > "%s_aml_code" is in use, where the prefix is a lowered case base
> > name of
> > the output file. In our case it will be "dsdt" producing a name as
> > "dsdt_aml_code".
> > 
> > The quick solution is to call sed which replaces new name by the old
> > one
> > to keep compatibility with old version of iASL.
> > 
> > The long term solution would be to modify code to use the new name
> > because it more scalable.
> 
> it *is* more scalable.

Yes, thanks.

> 
> > 
> > Cc: Robert Moore <robert.moore@intel.com>
> > Cc: Sami Mujawar <sami.mujawar@arm.com>
> > Cc: Evan Lloyd <evan.lloyd@arm.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  scripts/Makefile.lib | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> > index f9809ce7ce..b5cf7e5427 100644
> > --- a/scripts/Makefile.lib
> > +++ b/scripts/Makefile.lib
> > @@ -416,6 +416,7 @@ cmd_acpi_c_asl=         \
> > 
> >  $(obj)/dsdt.c:    $(src)/dsdt.asl
> >         $(call cmd,acpi_c_asl)
> > +       $(Q)sed -i -e "s,dsdt_aml_code,AmlCode," $@
> > 
> >  # Bzip2
> >  # ---------------------------------------------------------------
> > ------------
> > --
> 
> Otherwise,
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> 
> Regards,
> Bin

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy