From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Scholz Date: Tue, 03 Aug 2004 15:37:30 +0200 Subject: [U-Boot-Users] [PATCH] Generic Support for Motorola i.MX architecture In-Reply-To: <20040803132755.AED8CC109F@atlas.denx.de> References: <20040803132755.AED8CC109F@atlas.denx.de> Message-ID: <410F951A.6020804@imc-berlin.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > In message <410F766F.2020106@imc-berlin.de> you wrote: >>A while ago I suggested to create cpu/imx, cpu/s3c24x0 etc. and put all the >>cpu specific stuff in there. > > > Agreed. Please submit a patch. > ARM9 generic code should stay in cpu/arm920t/ > >>1.) cpu/at91rm9200/Makefile: >> >> OBJS = ../arm920t/interrupts.o ../arm920t/cpu.o \ >> serial.o at91rm9200_ether.o at45.o >> >> start.S has to be a link "start.S -> ../arm920t/start.S" since > > > No. > > >>2.) Or creating (by Makefile) links to the generic sources: >> >> LINKS = start.S interrupts.c cpu.c >> >> $(LINKS) >> ln -s ../arm920t/$@ $@ (oder s.?.) > > > No. > > >>Comments? > > > Both methods don't look really attractive to me. If ther eis common > code, it shall remain in the common directory. But how else could we solve this? If we leave the common arm920t code in cpu/arm920t and put the specific stuff in - let's say - cpu/s3c24x0... The main makefile only takes one cpu type. How can we achieve that the code in cpu/arm920t _and_ in cpu/s3c24x0 is built? -- Steven Scholz