From: Pantelis Antoniou <panto@intracom.gr>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Fix serial hangs when CONFIG_SERIAL_MULTI is defined
Date: Tue, 14 Sep 2004 11:06:37 +0300 [thread overview]
Message-ID: <4146A68D.2050309@intracom.gr> (raw)
In-Reply-To: <fc.004c4e480028bf083b9aca004d34f1de.28bf20@rea.de>
Anders Larsen wrote:
> Pantelis Antoniou <panto@intracom.gr> wrote:
>
>>--- u-boot/common/serial.c 2004-08-02 01:48:18.000000000 +0300
>>+++ u-boot-cvs-work/common/serial.c 2004-09-07 14:23:44.000000000 +0300
>>@@ -102,6 +102,8 @@
>>{
>> struct serial_device *s;
>>
>>+ return 0;
>>+
>> for (s = serial_devices; s; s = s->next)
>> {
>> if (strcmp(s->name, name) == 0)
>
>
> Hi,
>
> is it intentional that you disable the body of that function?
> If yes, why not remove it entirely?
>
> Cheers
> Anders
>
>
>
OBVIOUSLY IT IS WRONG.
Damn, good catch.
Remove the return 0 please.
Regards
Pantelis
next prev parent reply other threads:[~2004-09-14 8:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-14 7:33 [U-Boot-Users] [PATCH] Fix serial hangs when CONFIG_SERIAL_MULTI is defined Pantelis Antoniou
2004-09-14 8:01 ` Anders Larsen
2004-09-14 8:06 ` Pantelis Antoniou [this message]
2004-09-14 9:22 ` Wolfgang Denk
2004-09-14 9:32 ` Pantelis Antoniou
2004-10-11 22:43 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4146A68D.2050309@intracom.gr \
--to=panto@intracom.gr \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox