From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pantelis Antoniou Date: Tue, 14 Sep 2004 11:06:37 +0300 Subject: [U-Boot-Users] [PATCH] Fix serial hangs when CONFIG_SERIAL_MULTI is defined In-Reply-To: References: <41469EE1.3040203@intracom.gr> Message-ID: <4146A68D.2050309@intracom.gr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Anders Larsen wrote: > Pantelis Antoniou wrote: > >>--- u-boot/common/serial.c 2004-08-02 01:48:18.000000000 +0300 >>+++ u-boot-cvs-work/common/serial.c 2004-09-07 14:23:44.000000000 +0300 >>@@ -102,6 +102,8 @@ >>{ >> struct serial_device *s; >> >>+ return 0; >>+ >> for (s = serial_devices; s; s = s->next) >> { >> if (strcmp(s->name, name) == 0) > > > Hi, > > is it intentional that you disable the body of that function? > If yes, why not remove it entirely? > > Cheers > Anders > > > OBVIOUSLY IT IS WRONG. Damn, good catch. Remove the return 0 please. Regards Pantelis