* [U-Boot-Users] [PATCH] Fix serial hangs when CONFIG_SERIAL_MULTI is defined
@ 2004-09-14 7:33 Pantelis Antoniou
2004-09-14 8:01 ` Anders Larsen
2004-10-11 22:43 ` Wolfgang Denk
0 siblings, 2 replies; 6+ messages in thread
From: Pantelis Antoniou @ 2004-09-14 7:33 UTC (permalink / raw)
To: u-boot
Hi
The following patch fixes the hangs in the serial port
when outputting very early.
Testing for global vars early in the boot sequence has
unintended consequences so just we check by the GD RELOC
flag which is safe to do anytime.
Regards
Pantelis
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: serial-fix.changelog
Url: http://lists.denx.de/pipermail/u-boot/attachments/20040914/4b7a4900/attachment.txt
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: serial-fix.diffstat
Url: http://lists.denx.de/pipermail/u-boot/attachments/20040914/4b7a4900/attachment-0001.txt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: serial-fix.patch
Type: text/x-patch
Size: 2171 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20040914/4b7a4900/attachment.bin
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot-Users] [PATCH] Fix serial hangs when CONFIG_SERIAL_MULTI is defined
2004-09-14 7:33 [U-Boot-Users] [PATCH] Fix serial hangs when CONFIG_SERIAL_MULTI is defined Pantelis Antoniou
@ 2004-09-14 8:01 ` Anders Larsen
2004-09-14 8:06 ` Pantelis Antoniou
2004-10-11 22:43 ` Wolfgang Denk
1 sibling, 1 reply; 6+ messages in thread
From: Anders Larsen @ 2004-09-14 8:01 UTC (permalink / raw)
To: u-boot
Pantelis Antoniou <panto@intracom.gr> wrote:
>--- u-boot/common/serial.c 2004-08-02 01:48:18.000000000 +0300
>+++ u-boot-cvs-work/common/serial.c 2004-09-07 14:23:44.000000000 +0300
>@@ -102,6 +102,8 @@
> {
> struct serial_device *s;
>
>+ return 0;
>+
> for (s = serial_devices; s; s = s->next)
> {
> if (strcmp(s->name, name) == 0)
Hi,
is it intentional that you disable the body of that function?
If yes, why not remove it entirely?
Cheers
Anders
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot-Users] [PATCH] Fix serial hangs when CONFIG_SERIAL_MULTI is defined
2004-09-14 8:01 ` Anders Larsen
@ 2004-09-14 8:06 ` Pantelis Antoniou
2004-09-14 9:22 ` Wolfgang Denk
0 siblings, 1 reply; 6+ messages in thread
From: Pantelis Antoniou @ 2004-09-14 8:06 UTC (permalink / raw)
To: u-boot
Anders Larsen wrote:
> Pantelis Antoniou <panto@intracom.gr> wrote:
>
>>--- u-boot/common/serial.c 2004-08-02 01:48:18.000000000 +0300
>>+++ u-boot-cvs-work/common/serial.c 2004-09-07 14:23:44.000000000 +0300
>>@@ -102,6 +102,8 @@
>>{
>> struct serial_device *s;
>>
>>+ return 0;
>>+
>> for (s = serial_devices; s; s = s->next)
>> {
>> if (strcmp(s->name, name) == 0)
>
>
> Hi,
>
> is it intentional that you disable the body of that function?
> If yes, why not remove it entirely?
>
> Cheers
> Anders
>
>
>
OBVIOUSLY IT IS WRONG.
Damn, good catch.
Remove the return 0 please.
Regards
Pantelis
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot-Users] [PATCH] Fix serial hangs when CONFIG_SERIAL_MULTI is defined
2004-09-14 8:06 ` Pantelis Antoniou
@ 2004-09-14 9:22 ` Wolfgang Denk
2004-09-14 9:32 ` Pantelis Antoniou
0 siblings, 1 reply; 6+ messages in thread
From: Wolfgang Denk @ 2004-09-14 9:22 UTC (permalink / raw)
To: u-boot
In message <4146A68D.2050309@intracom.gr> you wrote:
>
> > is it intentional that you disable the body of that function?
> > If yes, why not remove it entirely?
...
> OBVIOUSLY IT IS WRONG.
>
> Damn, good catch.
>
> Remove the return 0 please.
Please submit a fixed patch.
Best regards,
Wolfgang Denk
--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de
...computer hardware progress is so fast. No other technology since
civilization began has seen six orders of magnitude in performance-
price gain in 30 years. - Fred Brooks, Jr.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot-Users] [PATCH] Fix serial hangs when CONFIG_SERIAL_MULTI is defined
2004-09-14 7:33 [U-Boot-Users] [PATCH] Fix serial hangs when CONFIG_SERIAL_MULTI is defined Pantelis Antoniou
2004-09-14 8:01 ` Anders Larsen
@ 2004-10-11 22:43 ` Wolfgang Denk
1 sibling, 0 replies; 6+ messages in thread
From: Wolfgang Denk @ 2004-10-11 22:43 UTC (permalink / raw)
To: u-boot
In message <41469EE1.3040203@intracom.gr> you wrote:
>
> * Patch by Pantelis Antoniou, 14 Sep 2004:
> Fix early serial hang when CONFIG_SERIAL_MULTI is defined.
Added (slightly modified to keep the code readable).
Best regards,
Wolfgang Denk
--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de
If the car industry behaved like the computer industry over the last
30 years, a Rolls-Royce would cost $5, get 300 miles per gallon, and
blow up once a year killing all passengers inside.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-10-11 22:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-14 7:33 [U-Boot-Users] [PATCH] Fix serial hangs when CONFIG_SERIAL_MULTI is defined Pantelis Antoniou
2004-09-14 8:01 ` Anders Larsen
2004-09-14 8:06 ` Pantelis Antoniou
2004-09-14 9:22 ` Wolfgang Denk
2004-09-14 9:32 ` Pantelis Antoniou
2004-10-11 22:43 ` Wolfgang Denk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox