[U-Boot-Users] [PATCH] fix warnings in board/versatile/flash.c

[U-Boot-Users] [PATCH] fix warnings in board/versatile/flash.c

[Steven Scholz]

CHANGELOG:

Fix typo and warning in board/versatile/flash.c

-- 
Steven
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: fix_warning_versatile.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20041018/fe5acc71/attachment.txt 

[U-Boot-Users] [PATCH] fix warnings in board/versatile/flash.c

[Wolfgang Denk]

Dear Steven,

in message <41736B80.1090903@imc-berlin.de> you wrote:
> 
> CHANGELOG:
> Fix typo and warning in board/versatile/flash.c

Please check again.

> -		printf ("\Intel StrataFlash 28F256K3C device initialized\n");
> +		printf ("Intel StrataFlash 28F256K3C device initialized\n");

This is already fixed in CVS.

> -		printf ("not erased at %08lx (%x)\n", (ulong) addr, *addr);
> +		printf ("not erased at %08lx (%lx)\n", (ulong) addr, *addr);

I don't get a warning for this code, neither with GCC-2.95.4 nor with
GCC-3.3.3. Which toolchain are you using, and what  is  the  error  /
warning message?

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Why is an average signature file longer than an average Perl script??

[U-Boot-Users] [PATCH] fix warnings in board/versatile/flash.c

[Steven Scholz]

Dear Wolfgang,

>>CHANGELOG:
>>Fix typo and warning in board/versatile/flash.c
> 
> 
> Please check again.
> This is already fixed in CVS.

Yes. Sorry. I just noticed that.

>>-		printf ("not erased at %08lx (%x)\n", (ulong) addr, *addr);
>>+		printf ("not erased at %08lx (%lx)\n", (ulong) addr, *addr);
> 
> I don't get a warning for this code, neither with GCC-2.95.4 nor with
> GCC-3.3.3. Which toolchain are you using, and what  is  the  error  /
> warning message?

I am using arm_920TDI-gcc Version 2.95.4 from you ELDK 2.1 and get

flash.c: In function `write_data':
flash.c:479: warning: unsigned int format, long unsigned int arg (arg 3)

--
Steven Scholz