From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Scholz Date: Mon, 25 Oct 2004 16:39:54 +0200 Subject: [U-Boot-Users] PATCH: Introducing CONFIG_BOARD_PRE_RESET In-Reply-To: <065ACD8E84315E4394C835E398C8D5EB90F440@COSSMGMBX02.email.corp.tld> References: <065ACD8E84315E4394C835E398C8D5EB90F440@COSSMGMBX02.email.corp.tld> Message-ID: <417D103A.9070506@imc-berlin.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Gerald, > I like your suggestion a lot, but I would suggest a "#ifdef" around the > common.h kind of like I hand-pasted in below (probably incorrectly, but > you get my meaning). > int board_postclk_init (void); > int board_early_init_r (void); > void board_poweroff (void); > +#ifdef CONFIG_BOARD_PRE_RESET > +void board_pre_reset (void); > +#endif Since functions like board_postclk_init and board_early_init_r etc. don't have an #ifdef I decided to go the same way. Do you see any problems without #ifdef ? -- Steven Scholz