[U-Boot-Users] PATCH: Introducing CONFIG_BOARD_PRE_RESET

Wolfgang Denk
2004-11-23T15:41:44Z

In message <41A346BD.2060207@imc-berlin.de> you wrote:
>
> > * Patch by Steven Scholz, 25 Oct 2004:
> > - Introducing CONFIG_BOARD_PRE_RESET and board_pre_reset() to allow
> > code to be executed before actually rebooting
>
> any new opinions on this topic?

No.

[Actually I think that it might make sense to perform certain cleanup
operations in case of an orderly reboot; on the other hand the reboot
code _must_not_ depend on such cleanup. In your case there seems to
be such a dependency. I'd rather see that you fix the reset code
first, and then (if there is still need for it) we might allow for
pre-reset cleanup functions.]

Best regards,

Wolfgang Denk

--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Quote from a recent meeting: "We are going to continue having these
meetings everyday until I find out why no work is getting done."