From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steven Scholz <steven.scholz@imc-berlin.de>
Date: Thu, 28 Oct 2004 09:36:33 +0200
Subject: [U-Boot-Users] PATCH: Introducing CONFIG_BOARD_PRE_RESET
In-Reply-To: <417E0B92.80700@imc-berlin.de>
References: <20041026082510.DDBF6C1430@atlas.denx.de> <417E0B92.80700@imc-berlin.de>
Message-ID: <4180A181.1060404@imc-berlin.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Wolfgang,

>>> Well, it's a bug in the CPU. If the LCDC DMA is running, the cpu 
>>> won't reboot with a simple "mov pc, r0".
>> Ummm... you don't call this a "reset", do you?
> Well that's what is done (work) for most ARM920T... Execeptions are
> 
> #ifdef CONFIG_S3C2400
>         bl      disable_interrupts
> # ifdef CONFIG_TRAB
>         bl      disable_vfd
> # endif
> ...
> 
> BTW cominh to think about it: Does "bl disable_vfd" by any chance 
> disable video controller for CONFIG_TRAB !?!? ;-)
> 
>> In your case, I think you really want to  implement  a  _real_  reset
>> function  that  takes the CPU back into it's virgin state. Is there a
>> watchdog on this hardware?
> 
> Sure. That means you have board _and_ cpu specific reset code!
> Some want to toggle a GPIO pin. Some want to use a cpu watchdog...
> So should we move the reset code out of cpu/arm920t/start.S into the 
> brand new cpu/arm920t/$(SOC)/reset.{S.c} !?

Any new opinions on this topic? Or is it closed for you and my suggestion rejected?

-- 
Steven Scholz