public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot-Users] Trouble on PXA w/kernel command-line
@ 2004-12-14 21:07 Craig A. Vanderborgh
  2004-12-14 21:30 ` Wolfgang Denk
  0 siblings, 1 reply; 6+ messages in thread
From: Craig A. Vanderborgh @ 2004-12-14 21:07 UTC (permalink / raw)
  To: u-boot

Hello:

I have u-boot up and running on my PXA-255 based custom board, and the 
linux kernel is booting and running.  GREAT!

The problem is that the command-line (as set in the u-boot environment 
variable) is not getting to the kernel.  This isn't a terribly serious 
problem but it's time for me to sort this out.

Please let me know what would be the best way to debug this problem, and 
where I ought to look for the problem in u-boot/kernel code.

Thanks in advance,
craig vanderborgh
voxware incorporated

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot-Users] Trouble on PXA w/kernel command-line
  2004-12-14 21:07 [U-Boot-Users] Trouble on PXA w/kernel command-line Craig A. Vanderborgh
@ 2004-12-14 21:30 ` Wolfgang Denk
  2004-12-14 21:39   ` Craig A. Vanderborgh
  0 siblings, 1 reply; 6+ messages in thread
From: Wolfgang Denk @ 2004-12-14 21:30 UTC (permalink / raw)
  To: u-boot

In message <41BF5627.9060407@voxware.com> you wrote:
> 
> The problem is that the command-line (as set in the u-boot environment 
> variable) is not getting to the kernel.  This isn't a terribly serious 
> problem but it's time for me to sort this out.

Is CONFIG_CMDLINE_TAG selected in your board config file?

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Houston, Tranquillity Base here.  The Eagle has landed.
                                                    -- Neil Armstrong

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot-Users] Trouble on PXA w/kernel command-line
  2004-12-14 21:30 ` Wolfgang Denk
@ 2004-12-14 21:39   ` Craig A. Vanderborgh
  2004-12-14 22:25     ` Wolfgang Denk
  0 siblings, 1 reply; 6+ messages in thread
From: Craig A. Vanderborgh @ 2004-12-14 21:39 UTC (permalink / raw)
  To: u-boot

Wolfgang Denk wrote:

>In message <41BF5627.9060407@voxware.com> you wrote:
>  
>
>>The problem is that the command-line (as set in the u-boot environment
>>    
>>
>
>  
>
>>variable) is not getting to the kernel.  This isn't a terribly serious
>>    
>>
>
>  
>
>>problem but it's time for me to sort this out.
>>    
>>
>
>Is CONFIG_CMDLINE_TAG selected in your board config file?
>
>Best regards,
>
>Wolfgang Denk
>
>  
>
Hello Wolfgang!

Yes, it is most definitely set.  Could you possibly describe how 
command-line passing is *supposed* to work and then I think I can fix it...

Thanks again for everything!!

craig

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot-Users] Trouble on PXA w/kernel command-line
  2004-12-14 21:39   ` Craig A. Vanderborgh
@ 2004-12-14 22:25     ` Wolfgang Denk
  2004-12-15  2:36       ` [U-Boot-Users] " craig vanderborgh
  0 siblings, 1 reply; 6+ messages in thread
From: Wolfgang Denk @ 2004-12-14 22:25 UTC (permalink / raw)
  To: u-boot

In message <41BF5D9D.50603@voxware.com> you wrote:
> 
> Yes, it is most definitely set.  Could you possibly describe how 
> command-line passing is *supposed* to work and then I think I can fix it...

See setup_commandline_tag() and do_bootm_linux() in
lib_arm/armlinux.c


Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You are only young once, but you can stay immature indefinitely.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot-Users] Re: Trouble on PXA w/kernel command-line
  2004-12-14 22:25     ` Wolfgang Denk
@ 2004-12-15  2:36       ` craig vanderborgh
  2004-12-15 11:23         ` Wolfgang Denk
  0 siblings, 1 reply; 6+ messages in thread
From: craig vanderborgh @ 2004-12-15  2:36 UTC (permalink / raw)
  To: u-boot

Wolfgang Denk <wd <at> denx.de> writes:

> 
> In message <41BF5D9D.50603 <at> voxware.com> you wrote:
> > 
> > Yes, it is most definitely set.  Could you possibly describe how 
> > command-line passing is *supposed* to work and then I think I can fix it...
> 
> See setup_commandline_tag() and do_bootm_linux() in
> lib_arm/armlinux.c
> 
> 
> Best regards,
> 
> Wolfgang Denk
> 

Hello Wolfgang:

It turns out that u-boot's handling of the command line is PERFECT.  Absolutely
spot-on.  The trouble was on the receiving end of the command line in my kernel.
My machine descriptor (in my processor setup C code) looked like this:

MACHINE_START(BITSYX, "Voxware/ADS BitsyX Lite")
	BOOT_MEM(0xa0000000, 0x40000000, io_p2v(0x40000000))
	MAPIO(bitsyx_map_io)
	INITIRQ(bitsyx_init_irq)
MACHINE_END

It lacked the "BOOT_PARAMS" macro that tells the kernel where in memory to look
for the command line.  Once I added a "BOOT_PARAMS" to my MACHINE descriptor
everything works perfectly:

MACHINE_START(BITSYX, "Voxware/ADS BitsyX Lite")
        BOOT_PARAMS(0xa0000100)
	BOOT_MEM(0xa0000000, 0x40000000, io_p2v(0x40000000))
	MAPIO(bitsyx_map_io)
	INITIRQ(bitsyx_init_irq)
MACHINE_END

I am sorry to bother you with such trivialities, but they are UNDOCUMENTED and
not at all obvious to people who don't regularly do Linux kernel work - like 
myself.

Thanks a MILLION.

Regards,
craig

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot-Users] Re: Trouble on PXA w/kernel command-line
  2004-12-15  2:36       ` [U-Boot-Users] " craig vanderborgh
@ 2004-12-15 11:23         ` Wolfgang Denk
  0 siblings, 0 replies; 6+ messages in thread
From: Wolfgang Denk @ 2004-12-15 11:23 UTC (permalink / raw)
  To: u-boot

In message <loom.20041215T032855-191@post.gmane.org> you wrote:
> 
> I am sorry to bother you with such trivialities, but they are UNDOCUMENTED and
> not at all obvious to people who don't regularly do Linux kernel work - like 
> myself.

Then please help improving the documentation. For example, you  could
add  an entry to the Linux FAQ section in the DULG - it takes no more
than 10 minutes, and might help others.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Love your country but never trust its government."
- from a hand-painted road sign in central Pennsylvania

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2004-12-15 11:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-12-14 21:07 [U-Boot-Users] Trouble on PXA w/kernel command-line Craig A. Vanderborgh
2004-12-14 21:30 ` Wolfgang Denk
2004-12-14 21:39   ` Craig A. Vanderborgh
2004-12-14 22:25     ` Wolfgang Denk
2004-12-15  2:36       ` [U-Boot-Users] " craig vanderborgh
2004-12-15 11:23         ` Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox