public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Cory Tusar <ctusar@videon-central.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Patch for Cirrus Logic EDB9312
Date: Tue, 18 Jan 2005 10:57:54 -0500	[thread overview]
Message-ID: <41ED3202.2050107@videon-central.com> (raw)
In-Reply-To: <6.0.1.1.0.20050118091601.01ba8630@192.168.2.1>

llandre wrote:
>> > here 
>> http://www.dave-tech.it/download/misc/sw/edb93xx/u-boot-edb93xx-3 is
>> > available for download a patch for Cirrus Logic EDB93xx.
>> > It has been tested on EDB9312.
>> > This patch is based on current CVS repository so it exploits Steven 
>> Scholz's
>> > SoC patch. See the attachment for the CHANGELOG.
>>
>> Sorry, but I reject this patch. It violates too many  of  the  Coding
>> Style  requirements  (C++ comments, trailing white space, no TABs for
>> indentation, actually TERRIBLE indentation, etc.)
>>
>> Please cleanup, reformat (using indent etc.) and resubmit.
> 
> 
> Hi Wolfgang,
> 
> to support this board I used several existing files that were
> not written following U-Boot coding rules :(
> Also I don't have the board anymore.
> I had a look at our web site usage statistics and a lot of people 
> downloaded
> the patch I released. Anybody can help about cleaning it up?

I'm in the process of cleaning this up, and verifying functionality on 
all EDB93xx variants, as I've got easy access to all of the boards. 
There were several issues I resolved in bringing U-Boot up on EDB9301 
hardware (notably broken ethernet drivers), along with a mess of cruft 
begging to be cleaned out.  Unfortunately this is a side-project of a 
current development effort, and so not something I can commit terribly 
many hours to.

-Cory


-- 
Cory T. Tusar
Embedded Systems Engineer
Videon Central, Inc.
2171 Sandy Drive
State College, PA 16801
(814) 235-1111 x316
(814) 235-1118 fax

"Debugging is twice as hard as writing the code in the first place.
   Therefore, if you write the code as cleverly as possible, you are,
     by definition, not smart enough to debug it."  --Brian W. Kernighan

  parent reply	other threads:[~2005-01-18 15:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4120DD8B.8040709@imc-berlin.de>
2004-10-09 22:20 ` [U-Boot-Users] Re: [PATCH] Cleanup cpu/arm920t using SoC Wolfgang Denk
2004-10-12 14:02   ` [U-Boot-Users] Patch for Cirrus Logic EDB9312 llandre
2005-01-09 23:43     ` Wolfgang Denk
2005-01-18  8:32       ` llandre
2005-01-18  9:28         ` [U-Boot-Users] Revision COntrol, Patch Database -- was: " Wolfgang Denk
2005-01-18  9:59           ` [U-Boot-Users] " llandre
2005-01-18 16:01           ` [U-Boot-Users] " Jerry Van Baren
2005-01-18 21:13             ` Wolfgang Denk
2005-01-18 22:49               ` [U-Boot-Users] Revision COntrol, Patch Database Jerry Van Baren
2005-01-21 17:42                 ` llandre
2005-01-19 10:28               ` [U-Boot-Users] Re: Revision COntrol, Patch Database -- was: Patch for Cirrus Logic EDB9312 Catalin Marinas
2005-01-19 15:56                 ` Jerry Van Baren
2005-01-24 17:14                   ` [U-Boot-Users] Re: Revision COntrol, Patch Database Jerry Van Baren
2005-01-24 18:33                     ` Catalin Marinas
2005-01-24 19:52                       ` Jerry Van Baren
2005-01-18 14:14         ` [U-Boot-Users] Patch for Cirrus Logic EDB9312 Cliff Brake
2005-01-19  8:33           ` llandre
2005-01-18 15:57         ` Cory Tusar [this message]
2005-01-19  8:35           ` llandre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41ED3202.2050107@videon-central.com \
    --to=ctusar@videon-central.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox