From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0797FC7EE23 for ; Mon, 22 May 2023 17:13:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AA58A84659; Mon, 22 May 2023 19:13:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="eerwfPZH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7F47484747; Mon, 22 May 2023 19:13:34 +0200 (CEST) Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C8B118445D for ; Mon, 22 May 2023 19:13:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=cfsworks@gmail.com Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-53404873a19so4377783a12.3 for ; Mon, 22 May 2023 10:13:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684775610; x=1687367610; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xoEQQJUxTRIflmiwdgauSYWk1oFf7Zd5RqiZlxmp+pU=; b=eerwfPZHeHC/wQJXpOiIoKcOWwckb+5r2epTUwXNyqI2aFZu7X7RhMivg62plBVtJs w492tr4OkqcDSdxKWrYlYXiyHB8uFS3r87cT6xgJTz3l0ZHUVgAdyQXT9UcbcZIpkJoU d7QCnoUtEiCcl8FVrwIhUIBULQMvdtVfL5t7+KrukoKJbgoDwnE/KP4rHD3fPIWYDAiU c1UVLbwUdMiz2Z4sr+I9QWu9056K3lN4XCWlWgrQom5IQfSJ809m25VI9tBNbH+9ou5d lRjVkYlT7S37VcTY95fumEc7UwC/yRXWWPPRvQyCgJ9Uu+OFhtY+m8Qaouy1KJFAA7dE Rr9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684775610; x=1687367610; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xoEQQJUxTRIflmiwdgauSYWk1oFf7Zd5RqiZlxmp+pU=; b=gVZ0TKc4Ddwowc8KtVKK+efx/pwIrOASgdos17F9tCTN1yTdjS+k+Pj8ByEjFb5V6t cikXQvNmWtb8HwnbItmN3yCkqhqoAIdsqJfHkySzmumLBwNf4z/+2KB5oihRlw90ZeeU R/CAaa9MCBaORWFD0xocR13mRolpfYBk9cyGqLmC2AG9DAe5s6gfIikIYNENglG9YSga RkuCqNsYFgHwBm8Z+lXm5p8vIpEjaMlPtWPLFaK0ALkPSPeRNJ40k1vy/ICLz3QvM/1S 1BN5rsN3k0dRUzXVGzl4V6SQbmRKLBSEbNnVz1KgqtxpYW5OdwjEUEIuTS/dPyhl2w3y 2L5g== X-Gm-Message-State: AC+VfDypsjK3q6fLE55hQZrVQRGQTgnOwG8j3Y8FZvVmhvskDSXvx6rZ iKectERpBXtVJ3NidshP2Rg= X-Google-Smtp-Source: ACHHUZ7YxdVwRwKnGI/iHE/mkKVQtv+bVvrw0czbdsWgeyIzcO7aAW1EpK0cSPZLaPf/T1NytKT8cg== X-Received: by 2002:a17:90a:f310:b0:255:8fd0:fc0e with SMTP id ca16-20020a17090af31000b002558fd0fc0emr1192845pjb.1.1684775610054; Mon, 22 May 2023 10:13:30 -0700 (PDT) Received: from [10.64.107.252] (static-198-54-134-172.cust.tzulo.com. [198.54.134.172]) by smtp.gmail.com with ESMTPSA id p1-20020a17090b010100b00250aa8ef89csm4437747pjz.18.2023.05.22.10.13.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 May 2023 10:13:29 -0700 (PDT) Message-ID: <41aaa868-3c90-f913-9231-8a11b6071db7@gmail.com> Date: Mon, 22 May 2023 11:13:27 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [RFC PATCH 08/10] arm: efi_loader: move .dynamic out of .text in EFI Content-Language: en-US To: Heinrich Schuchardt Cc: Ilias Apalodimas , Tom Rini , u-boot@lists.denx.de References: <20230520205547.1009254-1-CFSworks@gmail.com> <20230520205547.1009254-9-CFSworks@gmail.com> <5e1b1da7-3047-ca06-6b15-fc123b52c565@gmx.de> From: Sam Edwards In-Reply-To: <5e1b1da7-3047-ca06-6b15-fc123b52c565@gmx.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 5/22/23 02:10, Heinrich Schuchardt wrote: Hi Heinrich, > .dynamic should be aligned. Structure Elf64_Dyn requires at least 8 byte > alignment. As best as I can tell, linkers (certainly lld[1], apparently also GNU ld judging by its default linker scripts) themselves set the proper word alignment on the .dynamic section that they synthesize for their internal input object. That alignment requirement bubbles up to the output section, so explicit alignment here should not be necessary. > The symbol _etext below should be 512 aligned as in > arch/arm/lib/crt0_aarch64_efi.S we have set FileAlignment = 0x200. Ah, that definitely needs to be fixed since the .rela.* sections might not have the 512 alignment. I've updated my local branch, though this also needs to be addressed in the current master branch. Cheers, Sam [1]: https://github.com/llvm/llvm-project/blob/acce2a315945e386a7be6f014ebe90c2a28f38d9/lld/ELF/SyntheticSections.cpp#L1246