From: Jaehoon Chung <jh80.chung@gmail.com>
To: Andre Przywara <andre.przywara@arm.com>,
Jagan Teki <jagan@amarulasolutions.com>
Cc: Vignesh R <vigneshr@ti.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Mikhail Kalashnikov <iuncuim@gmail.com>,
Piotr Oniszczuk <piotr.oniszczuk@gmail.com>,
u-boot@lists.denx.de, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 2/3] sunxi: H616: remove default AXP305 selection
Date: Tue, 14 Nov 2023 22:24:37 +0900 [thread overview]
Message-ID: <41c7aa9d-9c7f-4a4a-a9d3-ec5c6909337d@gmail.com> (raw)
In-Reply-To: <20231114013106.31336-3-andre.przywara@arm.com>
On 11/14/23 10:31, Andre Przywara wrote:
> The original H616 devices released about three years ago were typically
> paired with an X-Powers AXP305 PMIC. Newer devices uses the smaller
> AXP313, and there seem to be far more systems with this PMIC around now.
>
> Remove the default AXP305 selection for the H616 SoC from the Kconfig,
> and move the PMIC selection into the board defconfig files instead.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards,
Jaehoon Chung
> ---
> configs/orangepi_zero2_defconfig | 1 +
> configs/x96_mate_defconfig | 1 +
> drivers/power/Kconfig | 1 -
> 3 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/configs/orangepi_zero2_defconfig b/configs/orangepi_zero2_defconfig
> index f13735e91c7..127cf9e365a 100644
> --- a/configs/orangepi_zero2_defconfig
> +++ b/configs/orangepi_zero2_defconfig
> @@ -19,6 +19,7 @@ CONFIG_SYS_I2C_SPEED=400000
> CONFIG_SPI_FLASH_MACRONIX=y
> CONFIG_PHY_REALTEK=y
> CONFIG_SUN8I_EMAC=y
> +CONFIG_AXP305_POWER=y
> CONFIG_SPI=y
> CONFIG_USB_EHCI_HCD=y
> CONFIG_USB_OHCI_HCD=y
> diff --git a/configs/x96_mate_defconfig b/configs/x96_mate_defconfig
> index 318951e19c2..e805e0952b3 100644
> --- a/configs/x96_mate_defconfig
> +++ b/configs/x96_mate_defconfig
> @@ -18,6 +18,7 @@ CONFIG_SPL_SYS_I2C_LEGACY=y
> CONFIG_SYS_I2C_MVTWSI=y
> CONFIG_SYS_I2C_SLAVE=0x7f
> CONFIG_SYS_I2C_SPEED=400000
> +CONFIG_AXP305_POWER=y
> CONFIG_SUPPORT_EMMC_BOOT=y
> CONFIG_USB_EHCI_HCD=y
> CONFIG_USB_OHCI_HCD=y
> diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
> index 2395720c99c..33b8bc1214d 100644
> --- a/drivers/power/Kconfig
> +++ b/drivers/power/Kconfig
> @@ -56,7 +56,6 @@ choice
> depends on ARCH_SUNXI
> default AXP209_POWER if MACH_SUN4I || MACH_SUN5I || MACH_SUN7I
> default AXP221_POWER if MACH_SUN6I || MACH_SUN8I_A23 || MACH_SUN8I_A33 || MACH_SUN8I_R40
> - default AXP305_POWER if MACH_SUN50I_H616
> default AXP818_POWER if MACH_SUN8I_A83T
> default SUNXI_NO_PMIC if MACH_SUNXI_H3_H5 || MACH_SUN50I || MACH_SUN8I_V3S
>
next prev parent reply other threads:[~2023-11-14 13:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 1:31 [PATCH 0/3] sunxi: add OrangePi Zero 3 board support Andre Przywara
2023-11-14 1:31 ` [PATCH 1/3] mtd: spi-nor: Add support for zBIT ZB25VQ128 Andre Przywara
2023-11-14 1:31 ` [PATCH 2/3] sunxi: H616: remove default AXP305 selection Andre Przywara
2023-11-14 13:24 ` Jaehoon Chung [this message]
2023-11-14 1:31 ` [PATCH 3/3] sunxi: H616: Add OrangePi Zero 3 board support Andre Przywara
2023-11-25 17:43 ` Mikhail Kalashnikov
2023-11-26 0:23 ` Andre Przywara
2023-11-26 4:27 ` Stephen Graf
2023-11-26 12:23 ` Andre Przywara
2023-11-27 20:21 ` Stephen Graf
2023-11-27 22:31 ` Stephen Graf
2023-11-28 1:37 ` Andre Przywara
2023-11-28 2:35 ` Stephen Graf
2023-11-28 6:03 ` Stephen Graf
2023-11-28 20:07 ` mdt_debug write Stephen Graf
2023-11-29 23:57 ` Andre Przywara
2023-11-30 0:20 ` Stephen Graf
2023-11-30 1:13 ` Stephen Graf
2023-12-01 0:27 ` Andre Przywara
2023-12-01 18:50 ` [PATCH 1/1] correct documentation for SPI flashing Stephen Graf
2023-12-03 23:40 ` Andre Przywara
2023-11-29 18:45 ` OrangePI Zero3 memory timing testing Stephen Graf
2023-11-30 0:10 ` Andre Przywara
2023-11-30 1:15 ` Siarhei Siamashka
2023-11-28 1:29 ` [PATCH 3/3] sunxi: H616: Add OrangePi Zero 3 board support Andre Przywara
2023-11-26 13:30 ` Mikhail Kalashnikov
2023-11-26 11:45 ` Bob McChesney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41c7aa9d-9c7f-4a4a-a9d3-ec5c6909337d@gmail.com \
--to=jh80.chung@gmail.com \
--cc=andre.przywara@arm.com \
--cc=iuncuim@gmail.com \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=piotr.oniszczuk@gmail.com \
--cc=u-boot@lists.denx.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox