public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andrew E Mileski <andrewm@isoar.ca>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Patch: Typos in include/ppc440.h
Date: Fri, 04 Feb 2005 16:56:08 -0500	[thread overview]
Message-ID: <4203EF78.3030909@isoar.ca> (raw)

This is in CVS as well as u-boot-1.1.2.tar.bz2 and as far back
as at least u-boot-0.2.0.tar.bz2

File: include/ppc440.h
Line:235
Context:
#define pbear	0x20	/* periph bus error addr reg		*/
#define pbesr	0x21	/* periph bus error status reg		*/
#define xbcfg	0x23	/* external bus configuration reg	*/
#define xbcid	0x23	/* external bus core id reg		*/
               	^^^^
According to the 440GX user manual (mine's dated Nov 21, 2003)
table 4-13 on page 186, EBC0_CID the "EBCO Peripheral Core ID Register"
is located at offset 0x24.  This register is not currently referenced by
any code in the u-boot-1.1.2.tar.bz2 release, which explains why it has
survied so long.

Also note that the header comment for this section has a typo, which
is also corrected in the attached patch.

--
Andrew E. Mileski

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: xbcid.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20050204/48eb0951/attachment.txt 

             reply	other threads:[~2005-02-04 21:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-04 21:56 Andrew E Mileski [this message]
2005-09-25 14:02 ` [U-Boot-Users] Patch: Typos in include/ppc440.h Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4203EF78.3030909@isoar.ca \
    --to=andrewm@isoar.ca \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox