[U-Boot-Users] Patch: Typos in include/ppc440.h

[U-Boot-Users] Patch: Typos in include/ppc440.h

[Andrew E Mileski]

This is in CVS as well as u-boot-1.1.2.tar.bz2 and as far back
as at least u-boot-0.2.0.tar.bz2

File: include/ppc440.h
Line:235
Context:
#define pbear	0x20	/* periph bus error addr reg		*/
#define pbesr	0x21	/* periph bus error status reg		*/
#define xbcfg	0x23	/* external bus configuration reg	*/
#define xbcid	0x23	/* external bus core id reg		*/
               	^^^^
According to the 440GX user manual (mine's dated Nov 21, 2003)
table 4-13 on page 186, EBC0_CID the "EBCO Peripheral Core ID Register"
is located at offset 0x24.  This register is not currently referenced by
any code in the u-boot-1.1.2.tar.bz2 release, which explains why it has
survied so long.

Also note that the header comment for this section has a typo, which
is also corrected in the attached patch.

--
Andrew E. Mileski

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: xbcid.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20050204/48eb0951/attachment.txt 

[U-Boot-Users] Patch: Typos in include/ppc440.h

[Wolfgang Denk]

In message <4203EF78.3030909@isoar.ca> you wrote:
>
> According to the 440GX user manual (mine's dated Nov 21, 2003)
> table 4-13 on page 186, EBC0_CID the "EBCO Peripheral Core ID Register"
> is located at offset 0x24.  This register is not currently referenced by
> any code in the u-boot-1.1.2.tar.bz2 release, which explains why it has
> survied so long.
> 
> Also note that the header comment for this section has a typo, which
> is also corrected in the attached patch.

Added, thanks. But please provide a CHANGELOG entry next time.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Any time things appear to be going better, you have overlooked  some-
thing.