From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andre Heider <a.heider@gmail.com>
Date: Tue, 26 Nov 2019 13:12:58 +0100
Subject: [U-Boot] [PATCH v2 1/4] sunxi: board: Use
	eth_env_set_enetaddr_by_index()
In-Reply-To: <20191126102241.gfbosmfsvmgxwu5p@core.my.home>
References: <20191126081602.2264519-1-a.heider@gmail.com>
 <20191126081602.2264519-2-a.heider@gmail.com>
 <20191126102241.gfbosmfsvmgxwu5p@core.my.home>
Message-ID: <420df73b-c49f-bbfd-d1c4-7be2bf834a2c@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: quoted-printable
To: u-boot@lists.denx.de

On 26/11/2019 11:22, Ond=C5=99ej Jirman wrote:
> Hello,
>=20
> On Tue, Nov 26, 2019 at 09:15:59AM +0100, Andre Heider wrote:
>> That helper takes care of assembling the correct name and doesn't allow
>> overwriting existing env vars, so drop the checks here.
>>
>> Signed-off-by: Andre Heider <a.heider@gmail.com>
>> ---
>>   board/sunxi/board.c | 10 +---------
>>   1 file changed, 1 insertion(+), 9 deletions(-)
>>
>> diff --git a/board/sunxi/board.c b/board/sunxi/board.c
>> index e3b2d13892..bb35d6b66e 100644
>> --- a/board/sunxi/board.c
>> +++ b/board/sunxi/board.c
>> @@ -807,14 +807,6 @@ static void setup_environment(const void *fdt)
>>   			if (!fdt_get_alias(fdt, ethaddr))
>>   				continue;
>>  =20
>> -			if (i =3D=3D 0)
>> -				strcpy(ethaddr, "ethaddr");
>> -			else
>> -				sprintf(ethaddr, "eth%daddr", i);
>> -
>> -			if (env_get(ethaddr))
>> -				continue;
>> -
>>   			/* Non OUI / registered MAC address */
>>   			mac_addr[0] =3D (i << 4) | 0x02;
>>   			mac_addr[1] =3D (sid[0] >>  0) & 0xff;
>> @@ -823,7 +815,7 @@ static void setup_environment(const void *fdt)
>>   			mac_addr[4] =3D (sid[3] >>  8) & 0xff;
>>   			mac_addr[5] =3D (sid[3] >>  0) & 0xff;
>>  =20
>> -			eth_env_set_enetaddr(ethaddr, mac_addr);
>> +			eth_env_set_enetaddr_by_index("eth", i, mac_addr);
>=20
> This breaks the build with CONFIG_NET disabled in u-boot, since
> eth_env_set_enetaddr_by_index is only available in net/.
>=20
> arm-linux-musleabihf-ld.bfd: board/sunxi/built-in.o: in function `setup_e=
nvironment':
> board/sunxi/board.c:835: undefined reference to `eth_env_set_enetaddr_by_=
index'
>=20
> See this thread for more info:
>    https://www.mail-archive.com/u-boot at lists.denx.de/msg340785.html
>  =20
> Use of eth_env_set_enetaddr is temporarily broken on master too, because =
this
> is still waiting to be merged:
>=20
>    https://www.mail-archive.com/u-boot at lists.denx.de/msg340882.html

Ok, I'll drop the patch then, it was just a possible cleanup I stumbled=20
upon anyway.

I applied the patch you linked to and it indeed fixes the build with=20
CONFIG_NET=3Dn.

Thanks,
Andre