Re: [PATCH] arm64: zynqmp: Use CONFIG_SPL_FS_LOAD_PAYLOAD_NAME in binman

[Quentin Schulz <quentin.schulz@cherry.de>]

Hi Michal,

On 3/19/25 2:08 PM, Michal Simek wrote:
> u-boot.itb name is coming via CONFIG_SPL_FS_LOAD_PAYLOAD_NAME and it's

They are unrelated as far as I can tell?

Isn't CONFIG_SPL_FS_LOAD_PAYLOAD_NAME the name of the U-Boot FIT that 
the SPL is going to load from some filesystem?

u-boot.itb in the binman nodes below is the name of the generated U-Boot 
FIT on your disk.

Your disk FS != SPL FS, no?

I can get behind wanting the same name for the file on both FS, but the 
issue I have is the additional CONFIG_SPL_FS_LOAD_PAYLOAD_NAME #ifdef 
will prevent the generation of this U-Boot FIT image if the symbol isn't 
defined anymore (which is possible if SPL has no support for FS (ext4, 
fat, squashfs, semihosting)). U-Boot likely work just fine by trying to 
load u-boot.itb from another source no? (No experience with AMD, 
typically only Aarch64 for me, where u-boot.itb is usually loaded from a 
specific offset in the storage medium, outside of any FS).

Basically, do we really need to NOT build U-Boot FIT if 
SPL_FS_LOAD_PAYLOAD_NAME is not defined?

Cheers,
Quentin