From: Joachim Jaeger <jjaeger@fsforth.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Re: Your patch NAND READ.JFFS2S
Date: Wed, 16 Mar 2005 15:53:25 +0100 [thread overview]
Message-ID: <42384865.5080100@fsforth.de> (raw)
In-Reply-To: <4238282E.8080302@identecsolutions.de>
Hi,
you are right, the } has to be moved also.
So the correct patch is:
else if (cmdtail && !strncmp(cmdtail, ".jffs2s", 2)) {
cmd |= NANDRW_JFFS2; /* skip bad blocks (on read too) */
if (cmd & NANDRW_READ)
cmd |= NANDRW_JFFS2_SKIP; /* skip bad blocks (on
read too) */
+ }
+ else if (cmdtail && !strncmp(cmdtail, ".jffs2", 2))
+ cmd |= NANDRW_JFFS2; /* skip bad blocks */
Best regards
Joachim
Frieder Ferlemann wrote:
> Hi,
>
> this patch looks suspect:
>
> else if (cmdtail && !strncmp(cmdtail, ".jffs2s", 2)) {
> cmd |= NANDRW_JFFS2; /* skip bad blocks (on read too) */
> if (cmd & NANDRW_READ)
> cmd |= NANDRW_JFFS2_SKIP; /* skip bad blocks (on
> read too) */
> + else if (cmdtail && !strncmp(cmdtail, ".jffs2", 2))
> + cmd |= NANDRW_JFFS2; /* skip bad blocks */
> }
>
> fixing indentation it is:
>
> else if (cmdtail && !strncmp(cmdtail, ".jffs2s", 2)) {
> cmd |= NANDRW_JFFS2; /* skip bad blocks (on read too) */
> if (cmd & NANDRW_READ)
> cmd |= NANDRW_JFFS2_SKIP; /* skip bad blocks (on
> read too) */
> + else if (cmdtail && !strncmp(cmdtail, ".jffs2", 2))
> + cmd |= NANDRW_JFFS2; /* skip bad blocks */
> }
>
> which you probably don't intend?
--
*********************************************************
For more information: http://www.fsforth.de
*********************************************************
Joachim Jaeger
FS FORTH-SYSTEME GmbH
Kueferstr. 8, D-79206 Breisach
Phone: +49 (7667) 908-146, FAX +49 (7667) 908-246
next parent reply other threads:[~2005-03-16 14:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4238282E.8080302@identecsolutions.de>
2005-03-16 14:53 ` Joachim Jaeger [this message]
2005-03-16 15:37 ` [U-Boot-Users] Re: Your patch NAND READ.JFFS2S Wolfgang Denk
2005-03-16 16:08 ` Joachim Jaeger
2005-03-16 16:20 ` Wolfgang Denk
2005-03-18 11:36 ` Joachim Jaeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42384865.5080100@fsforth.de \
--to=jjaeger@fsforth.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox