From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joachim Jaeger Date: Wed, 16 Mar 2005 15:53:25 +0100 Subject: [U-Boot-Users] Re: Your patch NAND READ.JFFS2S In-Reply-To: <4238282E.8080302@identecsolutions.de> References: <4238282E.8080302@identecsolutions.de> Message-ID: <42384865.5080100@fsforth.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, you are right, the } has to be moved also. So the correct patch is: else if (cmdtail && !strncmp(cmdtail, ".jffs2s", 2)) { cmd |= NANDRW_JFFS2; /* skip bad blocks (on read too) */ if (cmd & NANDRW_READ) cmd |= NANDRW_JFFS2_SKIP; /* skip bad blocks (on read too) */ + } + else if (cmdtail && !strncmp(cmdtail, ".jffs2", 2)) + cmd |= NANDRW_JFFS2; /* skip bad blocks */ Best regards Joachim Frieder Ferlemann wrote: > Hi, > > this patch looks suspect: > > else if (cmdtail && !strncmp(cmdtail, ".jffs2s", 2)) { > cmd |= NANDRW_JFFS2; /* skip bad blocks (on read too) */ > if (cmd & NANDRW_READ) > cmd |= NANDRW_JFFS2_SKIP; /* skip bad blocks (on > read too) */ > + else if (cmdtail && !strncmp(cmdtail, ".jffs2", 2)) > + cmd |= NANDRW_JFFS2; /* skip bad blocks */ > } > > fixing indentation it is: > > else if (cmdtail && !strncmp(cmdtail, ".jffs2s", 2)) { > cmd |= NANDRW_JFFS2; /* skip bad blocks (on read too) */ > if (cmd & NANDRW_READ) > cmd |= NANDRW_JFFS2_SKIP; /* skip bad blocks (on > read too) */ > + else if (cmdtail && !strncmp(cmdtail, ".jffs2", 2)) > + cmd |= NANDRW_JFFS2; /* skip bad blocks */ > } > > which you probably don't intend? -- ********************************************************* For more information: http://www.fsforth.de ********************************************************* Joachim Jaeger FS FORTH-SYSTEME GmbH Kueferstr. 8, D-79206 Breisach Phone: +49 (7667) 908-146, FAX +49 (7667) 908-246