public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andrew Wozniak <awozniak@mc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] OCOTEA get_timer() bug
Date: Thu, 31 Mar 2005 13:26:22 -0500	[thread overview]
Message-ID: <424C40CE.5000202@mc.com> (raw)
In-Reply-To: <200503300913.32078.sr@denx.de>

Hello Stefan,

Testing on a real OCOTEA board will be a great help.

Our target is a custom 440gx board with an OCOTEA port of U-Boot. I will 
try to do some testing to determine if there are any side affects on our 
board.

-andrew

Stefan Roese wrote:
> Hello,
> 
> On Wednesday 30 March 2005 01:17, Andrew Wozniak wrote:
> 
> 
>>My only concern with the fix is that it will break something else that
>>assumes the timer interval to be 10msec.  There are a few "files" that
>>depend on it for timeout operations:
>>
>>cpu/ppc4xx/440gx_enet.c
>>          if ((time_now - time_start) > 3000)   <--- 30 sec timo?
> 
> 
> This is 440 specific, but in the comments a few lines above 3 seconds timeout 
> is mentioned. So even this seems to be a bug with a 10 ms timer interval.
> 
> 
>>net/bootp.c
>>	bp->bp_secs = htons(get_timer(0) / CFG_HZ);
>>	...
>>         BootpID += get_timer(0);
>>
>>net/tftp.c
>>	TftpOurPort = 1024 + (get_timer(0) % 3072);
>>
>>net/net.c
>>post/rtc.c
>>tools/updater/flash_hw.c
> 
> 
> All this is generic code (not 440 spcific), so a 1 ms timer interval is 
> assumed.
> 
> Give me a few days and I will test it on an OCOTEA board.
> 
> Best regards,
> Stefan
> 

  reply	other threads:[~2005-03-31 18:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-28 19:25 [U-Boot-Users] OCOTEA get_timer() bug Andrew Wozniak
2005-03-28 19:58 ` Wolfgang Denk
2005-03-29  6:26   ` Stefan Roese
2005-03-29 23:17     ` Andrew Wozniak
2005-03-30  7:13       ` Stefan Roese
2005-03-31 18:26         ` Andrew Wozniak [this message]
2005-04-04 17:35           ` Travis B. Sawyer
2005-04-05 13:26     ` Travis B. Sawyer
2005-04-05 14:08 ` Travis B. Sawyer
2005-04-05 22:52   ` Andrew Wozniak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=424C40CE.5000202@mc.com \
    --to=awozniak@mc.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox