public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Travis B. Sawyer <tsawyer+u-boot@sandburst.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] OCOTEA get_timer() bug
Date: Tue, 05 Apr 2005 09:26:28 -0400	[thread overview]
Message-ID: <42529204.50107@sandburst.com> (raw)
In-Reply-To: <200503290826.01044.sr@denx.de>

Stefan Roese wrote:
> On Monday 28 March 2005 21:58, Wolfgang Denk wrote:
> 
> 
>>>I've tested the following and propose it as a fix, replace this:
>>>   val = gd->bd->bi_intfreq/100;	 /* 10 msec */
>>>with:
>>>   val = gd->bd->bi_intfreq/1000; /* 1 msec */
>>>
>>>I've also tested some of the network related functions to insure that no
>>>timeout conditions have appeared.
>>>
>>>I want to post this patch but would prefer a code review from those that
>>>are more familiar with get_timer() use within the OCOTEA codebase.
>>
>>I don't know why the 440 is handled separately.
>>
>>Stefan, do you have an idea?
> 
> No. The 440 port was done by Scott McNutt <smcnutt@artsyncp.com>, if I 
> remember right. But it seems that the fix is correct. Scott (or any other 440 
> users), any comments on this?
> 
> Best regards,
> Stefan
> 

Looking back at my original patch (using sourceforge cvs browse)
The patch for the 440 GX did not change that portion of code, so the 
ebony should also exhibit this behavior.  I recently rx'ed a message 
from one of my users that the timer was returning ~10x of what was 
expected.  That should have been a clue to me...

I'll give the above fix a whirl on my custom board and report back.

-travis

  parent reply	other threads:[~2005-04-05 13:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-28 19:25 [U-Boot-Users] OCOTEA get_timer() bug Andrew Wozniak
2005-03-28 19:58 ` Wolfgang Denk
2005-03-29  6:26   ` Stefan Roese
2005-03-29 23:17     ` Andrew Wozniak
2005-03-30  7:13       ` Stefan Roese
2005-03-31 18:26         ` Andrew Wozniak
2005-04-04 17:35           ` Travis B. Sawyer
2005-04-05 13:26     ` Travis B. Sawyer [this message]
2005-04-05 14:08 ` Travis B. Sawyer
2005-04-05 22:52   ` Andrew Wozniak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42529204.50107@sandburst.com \
    --to=tsawyer+u-boot@sandburst.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox