From: Robert Whaley <rwhaley@applieddata.net>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Patch for ADSVIX single board computer with PXA27x processor
Date: Wed, 06 Apr 2005 08:59:47 -0400 [thread overview]
Message-ID: <4253DD43.1020401@applieddata.net> (raw)
In-Reply-To: <20050405235653.670F9C108D@atlas.denx.de>
Wolfgang Denk wrote:
> In message <41AB5DE0.1040402@applieddata.net> you wrote:
>
>>This patch adds support for the ADSVIX SBC with PXA27x processor.
>
>
> Mostly added.
>
> Please provide a proper patch next time (CHANGELOG entry), and stick
> to the Coding Style (indentation by TAB, no trailing white space,
> etc.)
Sorry.
>
> Here is what I rejected:
>
...
>
>
> diff -urN u-boot/examples/Makefile u-boot.vix/examples/Makefile
> --- u-boot/examples/Makefile 2004-10-10 17:27:33.000000000 -0400
> +++ u-boot.vix/examples/Makefile 2004-11-24 12:13:18.000000000 -0500
> @@ -30,7 +30,11 @@
> endif
>
> ifeq ($(ARCH),arm)
> -LOAD_ADDR = 0xc100000
> +ifeq ($(CPU),pxa)
> +LOAD_ADDR = 0xa1000000
> +else
> +LOAD_ADDR = 0xc1000000
> +endif
> endif
>
OK, but note that PXA DRAM can't be at 0xCxxxxxxx (that is a reserved
address) it has to be at 0xAxxxxxxx.
--
Robert Whaley
Applied Data Systems www.applieddata.net
434-244-9504 rwhaley at applieddata.net
next prev parent reply other threads:[~2005-04-06 12:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-29 17:35 [U-Boot-Users] Patch for ADSVIX single board computer with PXA27x processor Robert Whaley
2005-04-05 23:56 ` Wolfgang Denk
2005-04-06 12:59 ` Robert Whaley [this message]
2005-04-07 22:24 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4253DD43.1020401@applieddata.net \
--to=rwhaley@applieddata.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox