[U-Boot-Users] Patch for ADSVIX single board computer with PXA27x processor

[U-Boot-Users] Patch for ADSVIX single board computer with PXA27x processor

[Robert Whaley]

This patch adds support for the ADSVIX SBC with PXA27x processor.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: adsvix.diff.gz
Type: application/gzip
Size: 9915 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20041129/4280d4fa/attachment.bin 

[U-Boot-Users] Patch for ADSVIX single board computer with PXA27x processor

[Wolfgang Denk]

In message <41AB5DE0.1040402@applieddata.net> you wrote:
> 
> This patch adds support for the ADSVIX SBC with PXA27x processor.

Mostly added.

Please provide a proper patch next time (CHANGELOG entry), and  stick
to  the  Coding  Style  (indentation by TAB, no trailing white space,
etc.)

Here is what I rejected:


diff -urN u-boot/common/cmd_pcmcia.c u-boot.vix/common/cmd_pcmcia.c
--- u-boot/common/cmd_pcmcia.c	2004-04-18 13:39:39.000000000 -0400
+++ u-boot.vix/common/cmd_pcmcia.c	2004-11-24 12:13:18.000000000 -0500
@@ -382,6 +382,11 @@
 
 #endif /* EXADRON 1 */
 
+#ifdef CONFIG_ADSVIX
+	void pcmcia_power_on(void);
+	pcmcia_power_on();
+#endif
+
 	rc = check_ide_device (0);	/* use just slot 0 */
 
 	return rc;
@@ -445,6 +450,10 @@
 #ifdef CONFIG_PXA_PCMCIA
 static int pcmcia_off (void)
 {
+#ifdef CONFIG_ADSVIX
+        void pcmcia_power_off(void);
+        pcmcia_power_off();
+#endif
 	return 0;
 }
 #endif



Please implement this in a board independent way, something like

#ifdef CONFIG_BOARD_PCMCIA_POWERON
	boardpcmcia_power_on();
#endif

or so.


diff -urN u-boot/examples/Makefile u-boot.vix/examples/Makefile
--- u-boot/examples/Makefile	2004-10-10 17:27:33.000000000 -0400
+++ u-boot.vix/examples/Makefile	2004-11-24 12:13:18.000000000 -0500
@@ -30,7 +30,11 @@
 endif
 
 ifeq ($(ARCH),arm)
-LOAD_ADDR = 0xc100000
+ifeq ($(CPU),pxa)
+LOAD_ADDR = 0xa1000000
+else
+LOAD_ADDR = 0xc1000000
+endif
 endif
 

Please don't mess with other boards.


Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In general, if you think something isn't in Perl, try it out, because
it usually is :-) - Larry Wall in <1991Jul31.174523.9447@netlabs.com>

[U-Boot-Users] Patch for ADSVIX single board computer with PXA27x processor

[Robert Whaley]

Wolfgang Denk wrote:
> In message <41AB5DE0.1040402@applieddata.net> you wrote:
> 
>>This patch adds support for the ADSVIX SBC with PXA27x processor.
> 
> 
> Mostly added.
> 
> Please provide a proper patch next time (CHANGELOG entry), and  stick
> to  the  Coding  Style  (indentation by TAB, no trailing white space,
> etc.)

Sorry.

> 
> Here is what I rejected:
> 

...

> 
> 
> diff -urN u-boot/examples/Makefile u-boot.vix/examples/Makefile
> --- u-boot/examples/Makefile	2004-10-10 17:27:33.000000000 -0400
> +++ u-boot.vix/examples/Makefile	2004-11-24 12:13:18.000000000 -0500
> @@ -30,7 +30,11 @@
>  endif
>  
>  ifeq ($(ARCH),arm)
> -LOAD_ADDR = 0xc100000
> +ifeq ($(CPU),pxa)
> +LOAD_ADDR = 0xa1000000
> +else
> +LOAD_ADDR = 0xc1000000
> +endif
>  endif
>  

OK, but note that PXA DRAM can't be at 0xCxxxxxxx (that is a reserved 
address) it has to be at 0xAxxxxxxx.


-- 
Robert Whaley
Applied Data Systems            www.applieddata.net
434-244-9504		    rwhaley at applieddata.net

[U-Boot-Users] Patch for ADSVIX single board computer with PXA27x processor

[Wolfgang Denk]

In message <4253DD43.1020401@applieddata.net> you wrote:
>
> > diff -urN u-boot/examples/Makefile u-boot.vix/examples/Makefile
> > --- u-boot/examples/Makefile	2004-10-10 17:27:33.000000000 -0400
> > +++ u-boot.vix/examples/Makefile	2004-11-24 12:13:18.000000000 -0500
> > @@ -30,7 +30,11 @@
> >  endif
> >  
> >  ifeq ($(ARCH),arm)
> > -LOAD_ADDR = 0xc100000
> > +ifeq ($(CPU),pxa)
> > +LOAD_ADDR = 0xa1000000
> > +else
> > +LOAD_ADDR = 0xc1000000
> > +endif
> >  endif
> >  
> 
> OK, but note that PXA DRAM can't be at 0xCxxxxxxx (that is a reserved 
> address) it has to be at 0xAxxxxxxx.

Maybe. But then please don't mess with other baords (and  don't  tell
me that 0xc1000000 is the same as 0xc100000).

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Sorry, but my karma just ran over your dogma.