From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Whaley Date: Wed, 06 Apr 2005 08:59:47 -0400 Subject: [U-Boot-Users] Patch for ADSVIX single board computer with PXA27x processor In-Reply-To: <20050405235653.670F9C108D@atlas.denx.de> References: <20050405235653.670F9C108D@atlas.denx.de> Message-ID: <4253DD43.1020401@applieddata.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > In message <41AB5DE0.1040402@applieddata.net> you wrote: > >>This patch adds support for the ADSVIX SBC with PXA27x processor. > > > Mostly added. > > Please provide a proper patch next time (CHANGELOG entry), and stick > to the Coding Style (indentation by TAB, no trailing white space, > etc.) Sorry. > > Here is what I rejected: > ... > > > diff -urN u-boot/examples/Makefile u-boot.vix/examples/Makefile > --- u-boot/examples/Makefile 2004-10-10 17:27:33.000000000 -0400 > +++ u-boot.vix/examples/Makefile 2004-11-24 12:13:18.000000000 -0500 > @@ -30,7 +30,11 @@ > endif > > ifeq ($(ARCH),arm) > -LOAD_ADDR = 0xc100000 > +ifeq ($(CPU),pxa) > +LOAD_ADDR = 0xa1000000 > +else > +LOAD_ADDR = 0xc1000000 > +endif > endif > OK, but note that PXA DRAM can't be at 0xCxxxxxxx (that is a reserved address) it has to be at 0xAxxxxxxx. -- Robert Whaley Applied Data Systems www.applieddata.net 434-244-9504 rwhaley at applieddata.net