From: Reinhard Arlt <reinhard.arlt@t-online.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Strange code in NetReceive(..) in net.c
Date: Mon, 02 May 2005 21:47:49 +0200 [thread overview]
Message-ID: <427683E5.5050608@t-online.de> (raw)
Hallo,
if you look at the code for ICMP handling in NetReceive, you will see that:
-- For an ICMP_REDIR_HOST packet, the nc_input_packet code and then the
(*packetHandler) is called.
-- For an ICMP_ECHO_REPLY, the (*packetHandler) is called twice.
Is this is not intended, i can prepare a patch.
A "return" before the "break" in the ICMP_PROTO path and an "return"
before the "break" in the ICMP_ECHO_REPLY path will do it.
Else the comment after "(ip_>ip_p != IPPROTO_UDP)" should be corrected.
Reinhard
next reply other threads:[~2005-05-02 19:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-02 19:47 Reinhard Arlt [this message]
2005-05-02 20:44 ` [U-Boot-Users] Strange code in NetReceive(..) in net.c Wolfgang Denk
2005-05-09 8:12 ` Reinhard Arlt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=427683E5.5050608@t-online.de \
--to=reinhard.arlt@t-online.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox