From mboxrd@z Thu Jan  1 00:00:00 1970
From: Reinhard Arlt <reinhard.arlt@t-online.de>
Date: Mon, 02 May 2005 21:47:49 +0200
Subject: [U-Boot-Users] Strange code in NetReceive(..) in net.c
Message-ID: <427683E5.5050608@t-online.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hallo,

if you look at the code for ICMP handling in NetReceive, you will see that:

-- For an ICMP_REDIR_HOST packet, the nc_input_packet code and then the 
(*packetHandler) is called.

-- For an ICMP_ECHO_REPLY, the (*packetHandler) is called twice.

Is this is not intended, i can prepare a patch.

A "return" before the "break" in the ICMP_PROTO path and an "return" 
before the "break" in the ICMP_ECHO_REPLY path will do it.

Else the comment after  "(ip_>ip_p != IPPROTO_UDP)" should be corrected.

Reinhard