From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?= Date: Sun, 29 Jul 2012 02:58:01 +0200 (CEST) Subject: [U-Boot] [PATCH 2/5] ehci-hcd: Boost transfer speed In-Reply-To: <454938890.703921.1343398424978.JavaMail.root@advansee.com> Message-ID: <428731893.759437.1343523481675.JavaMail.root@advansee.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Marek, On Fri, Jul 27, 2012 at 04:13:45 PM, Beno?t Th?baudeau wrote: > On Fri, Jul 27, 2012 at 04:01:11 PM, Marek Vasut wrote: > > [...] > > > > > + token = (toggle << 31) | > > > > > + (xfr_bytes << 16) | > > > > > + ((req == NULL ? 1 : 0) << 15) | > > > > > + (0 << 12) | > > > > > + (3 << 10) | > > > > > + ((usb_pipein(pipe) ? 1 : 0) << 8) | (0x80 << 0); > > > > > > > > If you could fix all this magic afterwards (not in these > > > > patches), > > > > that'd be > > > > great. > > > > > > Do you only mean #defining all those values? > > > > Yes, but let's do this in a subsequent patch. It can wait for > > later. > > OK. What would you think about merging that together with the definition of 4096 into the current patch 1/5? In the next version, this patch would thus become a general cosmetic patch for EHCI to define all used constants. Best regards, Beno?t