public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Greg Ungerer <gerg@moreton.com.au>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 1/2] add Kendein/Micrel KS8695P CPU support
Date: Fri, 20 May 2005 00:26:03 +1000	[thread overview]
Message-ID: <428CA1FB.8000407@moreton.com.au> (raw)
In-Reply-To: <20050517145335.DE474C1512@atlas.denx.de>

Hi Wolfgang,

Wolfgang Denk wrote:
> In message <4289FE13.7040708@moreton.com.au> you wrote:
>>Attached is a patch that adds support to u-boot for the Kendin/Micrel
>>KS8695P CPU. It is an ARM9 based SoC type device, used in a lot of
>>little routers.
>>
>>This patch was originally generated against u-boot 1.1.1.
> 
> Sorry, but your source base is just too old, and the patch as  is  is
> not  usable  any  more.  Please  note  that  there  has  been a major
> reorganisation to better support SoC systems like yours, too. Instead
> of duplicationg the same code again and again we now share the common
> parts.
> 
> Please rework your patch; do not create a  new  cpu/  directory,  but
> instead  a  new  SoC-specific subdirectory like those already present
> for at91rm9200 or s3c24x0 systems.

Here is a reworked patch, this time against the current CVS code.
How does this look?

I put it under the arm920t, though technicaly it is a 922t.
Seemed to fit in nicely in any case.


>>I am following up this patch with a couple of more patches that
>>add support for the OpenGear CM4008 and CM4116/CM4148 console
>>manager boards (that use the KS8695P CPU).
> 
> 
> Actually the order was different, but this doesn't matter:  all  your
> patches share the same problem. Please fix, and resubmit.

The first email (the ks8695 cpu support) bounced, it was larger
than 40k. So I had to split it and resend. Otherwise they would
have been in order :-)

Regards
Greg

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: u-boot.ks8695.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20050520/145026a3/attachment.txt 

  reply	other threads:[~2005-05-19 14:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-17 14:22 [U-Boot-Users] [PATCH 1/2] add Kendein/Micrel KS8695P CPU support Greg Ungerer
2005-05-17 14:53 ` Wolfgang Denk
2005-05-19 14:26   ` Greg Ungerer [this message]
2005-05-19 22:47     ` Wolfgang Denk
2005-05-20  9:20       ` richard at uclinux.net
2005-05-20 15:44         ` Wolfgang Denk
2005-05-23  1:22           ` Greg Ungerer
2005-05-23 11:08             ` Wolfgang Denk
2005-05-24  6:45               ` Greg Ungerer
2005-05-20 13:52       ` Greg Ungerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=428CA1FB.8000407@moreton.com.au \
    --to=gerg@moreton.com.au \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox