[U-Boot-Users] [PATCH] add OpenGear CM4008 board support

Wolfgang Denk
2005-05-19T22:47:40Z

In message <428CA2EE.2090405@moreton.com.au> you wrote:
>
> Revised patch against CVS source, adds support for the OpenGear
> CM4008 board (based on support for the ks8695 CPU).

Added, thanks.

Please don't add trailing white space
(board/cm4008/cm4008.c).

Note that your code references a non-existing U-Boot command "gofsk"!

Note that there are compiler warnings generated from your code:

ks8695eth.c: In function `eth_send':
ks8695eth.c:217: warning: passing arg 2 of `memcpy' discards qualifiers from pointer target type
ks8695eth.c:220: warning: passing arg 1 of `memset' makes pointer from integer without a cast

Please submit a (new, incremental) patch for this one!

Best regards,

Wolfgang Denk

--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There's no future in time travel.