From: Greg Ungerer <gerg@moreton.com.au>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 1/2] add Kendein/Micrel KS8695P CPU support
Date: Tue, 24 May 2005 16:45:19 +1000 [thread overview]
Message-ID: <4292CD7F.4070509@moreton.com.au> (raw)
In-Reply-To: <20050523110856.63907C1512@atlas.denx.de>
Hi Wolfgang,
Wolfgang Denk wrote:
> In message <42913054.3010901@moreton.com.au> you wrote:
>
>>Ok, it makes no sense (at least currently) to be compiling this driver
>>for any configuration not based on the KS8695 CPU. So the simple fix
>>is to define it out.
>
>
> Atually I think it makes sense to compile the driver only for those
> boards that enable it, as ther ecould be even KS8695 based boards
> that don't need / want to use this driver.
>
> Fixed that wat. Thanks.
Yes, that is true.
BTW, we could split out the defines specific to the ethernet driver
from that arch-ks8695/platform.h if that made sense. As it is currently
that platform.h is a direct copy of that file from the Linux support
for this device. It would be sorta nice if we can keep it that way,
no doubt it will get updated over time as KS release new parts in this
family (they have 3 in this CPU family currently).
Regards
Greg
next prev parent reply other threads:[~2005-05-24 6:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-17 14:22 [U-Boot-Users] [PATCH 1/2] add Kendein/Micrel KS8695P CPU support Greg Ungerer
2005-05-17 14:53 ` Wolfgang Denk
2005-05-19 14:26 ` Greg Ungerer
2005-05-19 22:47 ` Wolfgang Denk
2005-05-20 9:20 ` richard at uclinux.net
2005-05-20 15:44 ` Wolfgang Denk
2005-05-23 1:22 ` Greg Ungerer
2005-05-23 11:08 ` Wolfgang Denk
2005-05-24 6:45 ` Greg Ungerer [this message]
2005-05-20 13:52 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4292CD7F.4070509@moreton.com.au \
--to=gerg@moreton.com.au \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox