From: "Heiko Stübner" <heiko@sntech.de>
To: u-boot@lists.denx.de
Subject: [PATCH v6 1/8] lib: rsa: distinguish between tpl and spl for CONFIG_RSA_VERIFY
Date: Tue, 30 Jun 2020 14:49:09 +0200 [thread overview]
Message-ID: <4299790.87OlsGiZ6J@diego> (raw)
In-Reply-To: <20200618142328.1753036-1-heiko@sntech.de>
Am Donnerstag, 18. Juni 2020, 16:23:21 CEST schrieb Heiko Stuebner:
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> While the SPL may want to do signature checking this won't be
> the case for TPL in all cases, as TPL is mostly used when the
> amount of initial memory is not enough for a full SPL.
>
> So on a system where SPL uses DM but TPL does not we currently
> end up with a TPL compile error of:
>
> lib/rsa/rsa-verify.c:48:25: error: dereferencing pointer to incomplete type ?struct checksum_algo?
>
> To prevent that change the $(SPL_) to $(SPL_TPL_) to distinguish
> between both. If someone really needs FIT signature checking in
> TPL as well, a new TPL_RSA_VERIFY config symbol needs to be added.
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
with it looking like everybody is happy with the fixes series now,
whom do I need to pester into picking it up? :-D
Thanks
Heiko
> ---
> changes in v5:
> - drop change that belongs in patch 2/8
> changes in v4:
> - amound -> amount
> - found another entry to handle
> changes in v2:
> - fix typo "distinguis(h)"
>
> lib/rsa/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/rsa/Makefile b/lib/rsa/Makefile
> index 14ed3cb401..c61ebfd79e 100644
> --- a/lib/rsa/Makefile
> +++ b/lib/rsa/Makefile
> @@ -5,6 +5,6 @@
> # (C) Copyright 2000-2007
> # Wolfgang Denk, DENX Software Engineering, wd at denx.de.
>
> -obj-$(CONFIG_$(SPL_)RSA_VERIFY) += rsa-verify.o rsa-checksum.o
> +obj-$(CONFIG_$(SPL_TPL_)RSA_VERIFY) += rsa-verify.o rsa-checksum.o
> obj-$(CONFIG_RSA_VERIFY_WITH_PKEY) += rsa-keyprop.o
> obj-$(CONFIG_RSA_SOFTWARE_EXP) += rsa-mod-exp.o
>
next prev parent reply other threads:[~2020-06-30 12:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 14:23 [PATCH v6 1/8] lib: rsa: distinguish between tpl and spl for CONFIG_RSA_VERIFY Heiko Stuebner
2020-06-18 14:23 ` [PATCH v6 2/8] lib: rsa: take spl/non-spl into account when building rsa_verify_with_pkey() Heiko Stuebner
2020-06-26 1:12 ` Simon Glass
2020-07-09 0:23 ` Tom Rini
2020-06-18 14:23 ` [PATCH v6 3/8] lib: rsa: bring exp_len in line when generating a key_prop Heiko Stuebner
2020-06-26 1:12 ` Simon Glass
2020-07-09 0:23 ` Tom Rini
2020-06-18 14:23 ` [PATCH v6 4/8] lib: rsa: fix allocated size for rr and rrtmp in rsa_gen_key_prop() Heiko Stuebner
2020-06-26 1:12 ` Simon Glass
2020-07-07 20:05 ` Heinrich Schuchardt
2020-06-18 14:23 ` [PATCH v6 5/8] lib: rsa: free local arrays after use " Heiko Stuebner
2020-06-26 1:12 ` Simon Glass
2020-07-09 0:23 ` Tom Rini
2020-06-18 14:23 ` [PATCH v6 6/8] lib: rsa: add documentation to padding_pss_verify to document limitations Heiko Stuebner
2020-06-26 1:12 ` Simon Glass
2020-07-09 0:24 ` Tom Rini
2020-06-18 14:23 ` [PATCH v6 7/8] spl: fit: select SPL_HASH_SUPPORT for SPL_FIT_SIGNATURE Heiko Stuebner
2020-06-26 1:12 ` Simon Glass
2020-07-09 0:24 ` Tom Rini
2020-06-18 14:23 ` [PATCH v6 8/8] spl: fit: select SPL_CRYPTO_SUPPORT " Heiko Stuebner
2020-06-26 1:12 ` Simon Glass
2020-07-09 0:24 ` Tom Rini
2020-06-26 1:12 ` [PATCH v6 1/8] lib: rsa: distinguish between tpl and spl for CONFIG_RSA_VERIFY Simon Glass
2020-06-30 12:49 ` Heiko Stübner [this message]
2020-06-30 12:54 ` Heinrich Schuchardt
2020-07-09 0:23 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4299790.87OlsGiZ6J@diego \
--to=heiko@sntech.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox