public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tolunay Orkun <listmember@orkun.us>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] PATCH for drivers/cfi_flash.c
Date: Tue, 31 May 2005 15:54:43 -0500	[thread overview]
Message-ID: <429CCF13.6020809@orkun.us> (raw)
In-Reply-To: <20050531200526.D31DDC1512@atlas.denx.de>

Wolfgang Denk wrote:

>>>2) force a one tick delay no matter what in flash_status_check()
>>>      
>>>
>
>Actually it should read: round up always.
>  
>
>>Pro: Easy to do. Info structure contains correct values
>>Con: Rounding up tout is done every time we are in flash_status_check.
>>    
>>
>
>So what? Regarding the code size it does not matter if  we  round  up
>here  or there; regarding speed it does not matter either since we're
>going to enter some sort of delay loop anyway.
>
>This is the way to go.
>  
>

So it shall be ;) I'll submit a patch for this.

Question 1: Should I redo my last patch or submit a patch on top of it 
assuming that it will go through?

Question 2: Assuming I will re-work my original patch. I had also 
included a fix in my last patch for logic error in 
flash_full_status_check() but today Peter Pearse came forward saying 
that fix was part of his patch submitted in March. ( 
http://sourceforge.net/mailarchive/message.php?msg_id=11164812 ). 
However, I do not have access to the patch file mentioned in that 
messages to compare. Should I exclude this change from my patch?

  reply	other threads:[~2005-05-31 20:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-06  8:20 [U-Boot-Users] PATCH for drivers/cfi_flash.c Tolunay Orkun
2005-05-28 22:15 ` Andrew Dyer
2005-05-30  8:23   ` Wolfgang Denk
2005-05-31 16:14     ` Tolunay Orkun
2005-05-31 20:06       ` Wolfgang Denk
2005-05-31 16:02   ` Tolunay Orkun
2005-05-31 20:05     ` Wolfgang Denk
2005-05-31 20:54       ` Tolunay Orkun [this message]
2005-06-01  7:24         ` Wolfgang Denk
  -- strict thread matches above, loose matches on Subject: below --
2005-06-01  7:03 Peter Pearse
2005-07-03  0:50 Tolunay Orkun
2006-02-28 16:33 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=429CCF13.6020809@orkun.us \
    --to=listmember@orkun.us \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox