From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steven Scholz <steven.scholz@imc-berlin.de>
Date: Fri, 10 Jun 2005 13:51:40 +0200
Subject: [U-Boot-Users] byteorder of image_header_t members?
Message-ID: <42A97ECC.5030708@imc-berlin.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi there,

if uint32_t members of image_header_t are stored in network byteorder, then 
all references of these members should use ntohl(), right?

So should we fix this for instance:

#~> grep "\->ih_magic" *
cmd_autoscript.c:	if (ntohl(hdr->ih_magic) != IH_MAGIC) {
cmd_bootm.c:		if (ntohl(hdr->ih_magic) != IH_MAGIC) {
 >>> cmd_bootm.c:	if (hdr->ih_magic  != IH_MAGIC) {	<<<
cmd_bootm.c:		if (ntohl(hdr->ih_magic) != IH_MAGIC) {
cmd_bootm.c:		(ntohl(hdr->ih_magic) != IH_MAGIC))
 >>> cmd_doc.c:		if (hdr->ih_magic == IH_MAGIC) {	<<<
 >>> cmd_fdc.c:		if (hdr->ih_magic  != IH_MAGIC) {	<<<
cmd_fpga.c:		if (ntohl(hdr->ih_magic)  != IH_MAGIC) {
cmd_ide.c:		if (ntohl(hdr->ih_magic) != IH_MAGIC) {
cmd_nand.c:		if (ntohl(hdr->ih_magic) == IH_MAGIC) {
cmd_scsi.c:		if (ntohl(hdr->ih_magic) == IH_MAGIC) {
cmd_usb.c:		if (ntohl(hdr->ih_magic) != IH_MAGIC) {



-- 
Steven