From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 053AEC36002 for ; Mon, 24 Mar 2025 14:12:23 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 92596811BB; Mon, 24 Mar 2025 15:12:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1742825534; bh=5DceOIXQ+eLE+X+ntRFPdUTWo7EpnWenmyNvduRTOM4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Uej97qa46SdNfTZCvNaqTv6L8MdXYmc5kYXJeAL9FC7ISyl2VeewsukydEXkDZxzm c0COXdZlKRyVs0yBtbJjisafzfLdAVWQztEhJC8RLSl/pBPe3Aqi8f7UnMZYLMchOH WFMJmlgnVNGHuU4F10ds/nVDpIXMlyJqrHiXfaztmQljA2atgyYm9Gml1PmffwUB9t Y9vUexQuXlGgBVZydgow/wTmg3WXqbsbWE/wWMgx8efy0UxGGCleBQB2h1a9CBC2jf 6TA4Y0OFHi1fhpqvZXVBMa0ZdUEJHjQBkL8rKmmImGNod9l+zb/NrtPaFMdHpK8M3x KjxNK+lbo/KAA== Received: by phobos.denx.de (Postfix, from userid 109) id DDDCE805C3; Mon, 24 Mar 2025 15:12:13 +0100 (CET) Received: from mx.denx.de (mx.denx.de [IPv6:2a03:4000:64:cc:545d:19ff:fe05:8172]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1856480107 for ; Mon, 24 Mar 2025 15:12:10 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marex@denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=denx.de header.i=@denx.de header.b="OZCgVSKV"; dkim-atps=neutral Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 029F010290255; Mon, 24 Mar 2025 15:12:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=mx-20241105; t=1742825528; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=5DceOIXQ+eLE+X+ntRFPdUTWo7EpnWenmyNvduRTOM4=; b=OZCgVSKV9ZfydoSCsR7qfr/iYJqaSaJwJsjiYCnmyTS8fTVLS+K+/eTPj1erIsAenujNzd dLxwyfrwLvHz/bPzYG8UImDT25a8XIs4+AOxwIqq6PnSkYMqMaTSUgkaLcjIX5gQau1LlQ wrynxCo4uX2GJRrzX5YPj4t6RG30wZuvn9G28oL8HWnzs4cnqt7ioM3xpLwAC9Ue52yOvQ +N71ZHPjJV2vP2PzUox1MMhPgy2HAnHQ0hhaXoAT7JYuHR2ngxFjjcBbOwAqq8e+d7OgIv HjTwzSr5wYqSCNtO2ZLGSNdBcFFCL/ACXQJbuTbUVOYVHIzwdgK1UUAI0WESow== Message-ID: <42f53c19-de12-45c3-9091-2e6c23d1fcd4@denx.de> Date: Mon, 24 Mar 2025 14:53:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: dwc3: gadget: Fix match_ep callback for NXP UUU tool To: Francesco Dolcini , Mattijs Korpershoek Cc: u-boot@lists.denx.de, Alexander Sverdlin , Felipe Balbi , Lukasz Majewski , Neil Armstrong , Thinh Nguyen , Tom Rini References: <20250319220805.219001-1-marex@denx.de> <87a59gdofd.fsf@baylibre.com> <20250324080315.GA6932@francesco-nb> <87pli6esx0.fsf@baylibre.com> Content-Language: en-US From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 3/24/25 1:30 PM, Francesco Dolcini wrote: > On Mon, Mar 24, 2025 at 09:26:03AM +0100, Mattijs Korpershoek wrote: >> Hi Francesco, >> >> On lun., mars 24, 2025 at 09:03, Francesco Dolcini wrote: >> >>> Hello Mattijs, Marek >>> >>> On Thu, Mar 20, 2025 at 10:47:02AM +0100, Mattijs Korpershoek wrote: >>>> On mer., mars 19, 2025 at 23:07, Marek Vasut wrote: >>>> >>>>> The UUU tool excepts the interrupt-in endpoint to be ep1in, otherwise >>>>> it crashes. This is a result of the previous hard-coded EP setup in >>>>> drivers/usb/gadget/epautoconf.c which did special-case EP allocation >>>>> for SPL builds, and which was since converted to this callback, but >>>>> without the special-case EP allocation in SPL part. >>>>> >>>>> This reinstates the SPL part in an isolated manner, only for NXP iMX >>>>> SoCs, only for SPL builds, and only for the ep1in interrupt-in endpoint. >>> >>> UUU can (and in our case is) used also on non-NXP i.MX platforms. >>> What should we do? >> >> Do reproduce the problem (UUU tool crashes) on those platforms with >> recent U-Boot versions (v2024.10+) ? > > Not tested, my comment is purely based on the code and the commit message. > Older U-Boot versions (up to v2024.04, included) are working fine, with UUU used > with TI K3 SoCs (AM69, AM62, AM62P). Are you talking about the NXP UUU ? https://github.com/NXPmicro/mfgtools.git