From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugen.Hristev at microchip.com Date: Thu, 7 May 2020 11:54:39 +0000 Subject: [PATCH] arm: dtsi: sama5d2: Add uart4 definition to sama5d2.dtsi In-Reply-To: References: <7aa43973-c718-08e0-238b-0697eea8392c@microchip.com> Message-ID: <42fbcfde-548c-9011-0139-0e96042bdb3f@microchip.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07.05.2020 14:32, Tiaki Rice wrote: > Eugen, > > Thanks for the speedy reply, I did not know about this script! I must have glossed over it in the uboot patch documentation page. > > The commit line is 82 characters which is longer than the preferred max of 75. Oops. Don't think this warning would be stopping the patch going through though... > Hi, For sure that won't be a problem with patchwork. however , it looks like your patch is windows-generated ? That might be an issue, I do not know. Can you send me your patch as attachment file ? Thanks > > Here is the output for the patch: > ----- > $ ./scripts/checkpatch.pl 0001-dtsi-sama5d2-Add-uart4-definition-to-sama5d2.dtsi.patch > WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) > #7: > This patch adds support for uart4 to the processor level device tree include file. > > total: 0 errors, 1 warnings, 0 checks, 14 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or --fix-inplace. > > 0001-dtsi-sama5d2-Add-uart4-definition-to-sama5d2.dtsi.patch has style problems, please review. > > NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE PREFER_ETHER_ADDR_COPY USLEEP_RANGE > > NOTE: If any of the errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > ----- > > Regards, > > Tiaki Rice > > -----Original Message----- > From: Eugen.Hristev at microchip.com > Sent: Thursday, 7 May 2020 8:19 PM > To: tiakirice at hotmail.com > Cc: u-boot at lists.denx.de > Subject: Re: [PATCH] arm: dtsi: sama5d2: Add uart4 definition to sama5d2.dtsi > > On 07.05.2020 12:21, Tiaki Rice wrote: > >> Hello Eugen, >> >> I'm new to this whole mailing list patchwork thingy so I suspect I didn't quite submit the patch correctly, maybe you can point me in the right direction. >> >> What I did: >> - Made the changes on master and locally commited them >> - Created a patch using 'git format-patch' and modified the patch file email body. >> - Used 'git send-email' to send the patch to u-boot at lists.denx.de and >> Cc'd you >> >> This opened my Outlook of which I checked to make sure the email was plain text and then sent it. Any ideas? >> > > Hi Tiaki, > > From my perspective you did everything very well. The patch looks sent fine. I would only have one question, did you check your patch with the built-in perl script that automatically checks your patch for formatting ? > ./scripts/checkpatch.pl --strict > > About patchwork, I think it may be an issue with patchwork. > > Eugen > > >> >> Thanks in advance, >> >> Tiaki Rice >> >> -----Original Message----- >> From: Eugen.Hristev at microchip.com >> Sent: Thursday, 7 May 2020 7:12 PM >> To: tiakirice at hotmail.com; u-boot at lists.denx.de >> Subject: Re: [PATCH] arm: dtsi: sama5d2: Add uart4 definition to >> sama5d2.dtsi >> >> On 07.05.2020 07:43, Tiaki Rice wrote: >>> This patch adds support for uart4 to the processor level device tree include file. >>> >>> >>> Signed-off-by: Tiaki Rice >>> Cc: Eugen Hristev >>> --- >> >> Hi, >> >> Thanks for contributing ! >> >> I have an issue with this patch missing from patchwork. >> Anyone has any idea why that happened ? >> >> Eugen >> >>> arch/arm/dts/sama5d2.dtsi | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/arch/arm/dts/sama5d2.dtsi b/arch/arm/dts/sama5d2.dtsi >>> index 5adc47b906..6fb2cb25f9 100644 >>> --- a/arch/arm/dts/sama5d2.dtsi >>> +++ b/arch/arm/dts/sama5d2.dtsi >>> @@ -746,6 +746,14 @@ >>> status = "disabled"; >>> }; >>> >>> +uart4: serial at fc00c000 { >>> +compatible = "atmel,at91sam9260-usart"; reg = <0xfc00c000 0x100>; >>> +clocks = <&uart4_clk>; clock-names = "usart"; status = "disabled"; >>> +}; >>> + >>> i2c1: i2c at fc028000 { >>> compatible = "atmel,sama5d2-i2c"; >>> reg = <0xfc028000 0x100>; >>> -- >>> 2.22.0.windows.1 >>> >> >