From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcus Hall Date: Tue, 23 Aug 2005 15:01:53 -0600 Subject: [U-Boot-Users] Patch for drivers/cfi_flash.c; properly detect write errors. Message-ID: <430B8EC1.6090406@lucent.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello.. It seems that there is a minor problem in cfi_flash.c that prevents it from detecting that a flash write error has occurred. The first change in the attached patch is trivial, it just makes the strings output for a protected and a non-protected sector have the same length so the output looks prettier.. The second change is in flash_full_status_check(). We have just called flash_status_check() and then did a switch() on the vendor. For intel, we *should* check if there are any error bits if the previous call returned ERR_OK (Otherwise we will have output an error message in flash_status_check() already.) The original code would only check for error bits if flash_status_check() returns ERR_TIMEOUT. -- Marcus Hall marcushall at lucent.com -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: CFI_FLASH.patch Url: http://lists.denx.de/pipermail/u-boot/attachments/20050823/922fe166/attachment.txt