From: Steven Scholz <steven.scholz@imc-berlin.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 1/5][RESEND] CSB637 - add KB920x support
Date: Wed, 24 Aug 2005 11:28:23 +0200 [thread overview]
Message-ID: <430C3DB7.7040700@imc-berlin.de> (raw)
In-Reply-To: <1124875197l.27954l.3l@ecxwww1.reanet.de>
Anders,
> --- /dev/null
> +++ b/board/kb9202/kb9202.c
...
> +void lowlevel_init(void) {
> + /* Required by assembly functions - do nothing */
> +}
Why is this required?
> --- a/cpu/arm920t/at91rm9200/i2c.c
> +++ b/cpu/arm920t/at91rm9200/i2c.c
...
> +#ifdef CONFIG_KB920x
> + twi->TWI_IADR = addr;
> +#else
> /* Set TWI Internal Address Register with first messages data field */
> /* only one address byte is supported */
> if (alen > 0)
> twi->TWI_IADR = addr & 0xff;
> +#endif
Why is this required? IMHO we should avoid putting board dependend
DEFINES in common code.
--
Steven
next prev parent reply other threads:[~2005-08-24 9:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-24 9:19 [U-Boot-Users] [PATCH 1/5][RESEND] CSB637 - add KB920x support Anders Larsen
2005-08-24 9:28 ` Steven Scholz [this message]
2005-08-24 9:32 ` Anders Larsen
2005-08-24 22:59 ` kb_admin
2005-08-25 7:03 ` Steven Scholz
2005-08-25 13:42 ` [U-Boot-Users] [PATCH 1/5][RESEND #2] " Anders Larsen
2005-08-25 14:43 ` Steven Scholz
2005-08-25 14:49 ` Anders Larsen
2005-09-01 6:48 ` Peter Menzebach
2005-08-25 17:55 ` kb9200_dev at kwikbyte.com
2005-08-25 21:48 ` kb9200_dev at kwikbyte.com
2005-10-05 0:15 ` Wolfgang Denk
2005-10-05 16:44 ` Anders Larsen
2005-10-05 23:23 ` Wolfgang Denk
2005-08-25 7:07 ` [U-Boot-Users] [PATCH 1/5][RESEND] " Steven Scholz
2005-10-05 0:07 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=430C3DB7.7040700@imc-berlin.de \
--to=steven.scholz@imc-berlin.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox