From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steven Scholz <steven.scholz@imc-berlin.de>
Date: Wed, 24 Aug 2005 11:28:23 +0200
Subject: [U-Boot-Users] [PATCH 1/5][RESEND] CSB637 - add KB920x support
In-Reply-To: <1124875197l.27954l.3l@ecxwww1.reanet.de>
References: <1124875197l.27954l.3l@ecxwww1.reanet.de>
Message-ID: <430C3DB7.7040700@imc-berlin.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Anders,

> --- /dev/null
> +++ b/board/kb9202/kb9202.c
...
> +void lowlevel_init(void) {
> +	/* Required by assembly functions - do nothing	*/
> +}

Why is this required?

> --- a/cpu/arm920t/at91rm9200/i2c.c
> +++ b/cpu/arm920t/at91rm9200/i2c.c
...
> +#ifdef CONFIG_KB920x
> +	twi->TWI_IADR = addr;
> +#else
>  	/* Set TWI Internal Address Register with first messages data field */
>  	/* only one address byte is supported  */
>  	if (alen > 0)
>  		twi->TWI_IADR = addr & 0xff;
> +#endif

Why is this required? IMHO we should avoid putting board dependend
DEFINES in common code.

--
Steven