From: Steven Scholz <steven.scholz@imc-berlin.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Bug in AT91RM9200.h
Date: Mon, 10 Oct 2005 14:23:06 +0200 [thread overview]
Message-ID: <434A5D2A.6070906@imc-berlin.de> (raw)
In-Reply-To: <42FC666D.6060704@imc-berlin.de>
Guys,
A while ago I sent the following the the linux arm ML. I am sure this
applies to U-Boot as well!
> I just noticed the following:
>
> in incluse/asm-arm/mach-at91rm9200/AT91RM9200.h
>
> #define AT91C_SMC2_DBW (0x1 << 13) // (SMC2) Data Bus Width
>
> and drivers/pcmcia/at91_cf.c uses code like
>
> csr &= ~AT91C_SMC2_DBW;
>
> BUT:
>
> According to the User Man the "DBW: Data Bus Width" field is _TWO_ bits.
> Thus it should be
>
> #define AT91C_SMC2_DBW (0x3 << 13) // (SMC2) Data Bus Width
So please apply this trivial.
* Fix define in AT91RM9200.h
Patch by Steven Scholz, 10 Oct 2005
--
Steven
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: at91rm9200.h.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20051010/b3f32431/attachment.txt
next parent reply other threads:[~2005-10-10 12:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <42F82884.9090500@billgatliff.com>
[not found] ` <42FC666D.6060704@imc-berlin.de>
2005-10-10 12:23 ` Steven Scholz [this message]
2005-10-10 12:33 ` [U-Boot-Users] Bug in AT91RM9200.h Steven Scholz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=434A5D2A.6070906@imc-berlin.de \
--to=steven.scholz@imc-berlin.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox