From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Scholz Date: Mon, 10 Oct 2005 14:23:06 +0200 Subject: [U-Boot-Users] Bug in AT91RM9200.h In-Reply-To: <42FC666D.6060704@imc-berlin.de> References: <42F82884.9090500@billgatliff.com> <42FC666D.6060704@imc-berlin.de> Message-ID: <434A5D2A.6070906@imc-berlin.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Guys, A while ago I sent the following the the linux arm ML. I am sure this applies to U-Boot as well! > I just noticed the following: > > in incluse/asm-arm/mach-at91rm9200/AT91RM9200.h > > #define AT91C_SMC2_DBW (0x1 << 13) // (SMC2) Data Bus Width > > and drivers/pcmcia/at91_cf.c uses code like > > csr &= ~AT91C_SMC2_DBW; > > BUT: > > According to the User Man the "DBW: Data Bus Width" field is _TWO_ bits. > Thus it should be > > #define AT91C_SMC2_DBW (0x3 << 13) // (SMC2) Data Bus Width So please apply this trivial. * Fix define in AT91RM9200.h Patch by Steven Scholz, 10 Oct 2005 -- Steven -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: at91rm9200.h.patch Url: http://lists.denx.de/pipermail/u-boot/attachments/20051010/b3f32431/attachment.txt