[U-Boot-Users] [PATCH]Fix cc-option macro in config.mk

[U-Boot-Users] [PATCH]Fix cc-option macro in config.mk

[Paolo Broggini]

The following patch fix the compilation problem discussed in thread
"Problem building U-Boot for ARM target"

Best regards
-P.Broggini



Signed-off-by: Paolo Broggini <pbroggini@softool.ch>


CHANGELOG:
   Fix cc-option macro in config.mk, $(CFLAGS) dropped.
   Patch by Paolo Broggini, 12 Oct 2005


diff --git a/config.mk b/config.mk
--- a/config.mk
+++ b/config.mk
@@ -90,7 +90,7 @@ HOSTSTRIP	= strip
  # Option checker (courtesy linux kernel) to ensure
  # only supported compiler options are used
  #
-cc-option = $(shell if $(CC) $(CFLAGS) $(1) -S -o /dev/null -xc /dev/null \
+cc-option = $(shell if $(CC) $(1) -S -o /dev/null -xc /dev/null \
  		> /dev/null 2>&1; then echo "$(1)"; else echo "$(2)"; fi ;)

  #

[U-Boot-Users] [PATCH]Fix cc-option macro in config.mk

[Cory T. Tusar]

Paolo Broggini wrote:
> 
> The following patch fix the compilation problem discussed in thread
> "Problem building U-Boot for ARM target"
> 
> Best regards
> -P.Broggini

Bump & resubmit...

This particular issue broke cross-compilation for all of our ARM-based
projects following a repository sync yesterday.

The attached patch was generated against a 2005.11.29 CVS pull.

CHANGELOG:
* Patch by Cory Tusar, 30 Nov 2005:
* Original patch by Paolo Broggini, 12 Oct 2005:
   Fix cc-option macro in config.mk, $(CFLAGS) dropped.

-Cory


-- 
Cory T. Tusar
Embedded Systems Engineer
Videon Central, Inc.
2171 Sandy Drive
State College, PA 16801
(814) 235-1111 x316
(814) 235-1118 fax

"Debugging is twice as hard as writing the code in the first place.
   Therefore, if you write the code as cleverly as possible, you are,
     by definition, not smart enough to debug it."  --Brian W. Kernighan




-------------- next part --------------
A non-text attachment was scrubbed...
Name: cc-option_CFLAGS_removal.patch
Type: text/x-patch
Size: 554 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20051130/c9c5063c/attachment.bin 

[U-Boot-Users] [PATCH]Fix cc-option macro in config.mk

[Marco Cavallini]

> The following patch fix the compilation problem discussed in thread
> "Problem building U-Boot for ARM target"
>
> Best regards
> -P.Broggini
>
>
>
> Signed-off-by: Paolo Broggini <pbroggini@softool.ch>
>
>
> CHANGELOG:
>   Fix cc-option macro in config.mk, $(CFLAGS) dropped.
>   Patch by Paolo Broggini, 12 Oct 2005
>
>
> diff --git a/config.mk b/config.mk
> --- a/config.mk
> +++ b/config.mk
> @@ -90,7 +90,7 @@ HOSTSTRIP = strip
>  # Option checker (courtesy linux kernel) to ensure
>  # only supported compiler options are used
>  #
> -cc-option = $(shell if $(CC) $(CFLAGS) $(1) -S -o /dev/null -xc /dev/null 
> \
> +cc-option = $(shell if $(CC) $(1) -S -o /dev/null -xc /dev/null \
>  > /dev/null 2>&1; then echo "$(1)"; else echo "$(2)"; fi ;)
>
>  #
>

Hello all,
I have the same error
>>   cc1: invalid option 'abi=apcs-gnu'
with Freescale MC9328MX1 and some other ARM boards
and I wonder why this patch has not been
applied in 1.1.4.
Is it correct to use it ?
Should I expect to see it in next 1.1.5 ?

Thanks

Marco Cavallini
Koan s.a.s. - Bergamo - ITALIA
Embedded and Real-Time Software Engineering
www.koansoftware.com    |    www.klinux.org

[U-Boot-Users] [PATCH]Fix cc-option macro in config.mk

[Paolo Broggini]

Marco Cavallini ha scritto:
>>
>> CHANGELOG:
>>   Fix cc-option macro in config.mk, $(CFLAGS) dropped.
>>   Patch by Paolo Broggini, 12 Oct 2005
>>
>>
> 
> Hello all,
> I have the same error
> 
>>>   cc1: invalid option 'abi=apcs-gnu'
> 
> with Freescale MC9328MX1 and some other ARM boards
> and I wonder why this patch has not been
> applied in 1.1.4.
I don't know, maybe is still in Wolfgang's patch queue.

> Is it correct to use it ?
Without it I was unable to compile U-Boot.

Regards
-Paolo